Skip to content

gh-139590: Stricter ruff rules for Tools/wasm #139752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2025
Merged

gh-139590: Stricter ruff rules for Tools/wasm #139752

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20b8dfa
gh-139590: Stricter `ruff` rules for `Tools/wasm`
sobolevn Oct 8, 2025
f85cd31
Also enable `ruff check`
sobolevn Oct 8, 2025
458a45b
Update .pre-commit-config.yaml
sobolevn Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Tools/wasm/.ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,3 @@ select = [
"W", # pycodestyle
"YTT", # flake8-2020
]
ignore = [
"E501", # Line too long
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this one makes likely sense given we're auto-formatting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to keep it, so we can reduce the diff :)

"F541", # f-string without any placeholders
"PYI024", # Use `typing.NamedTuple` instead of `collections.namedtuple`
"PYI025", # Use `from collections.abc import Set as AbstractSet`
]
Loading