gh-139817: Fix refleak in TypeAliasType(qualname=non_string) #140197
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!buildbot AMD64.Fedora.Stable.Refleaks |
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 8c46640 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140197%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
efimov-mikhail
approved these changes
Oct 16, 2025
| Py_DECREF(module); | ||
| return NULL; | ||
| } | ||
| } |
There was a problem hiding this comment.
IMO, it's better to place obtaining of module after qualname related if-block and remove a call of Py_DECREF(module).
efimov-mikhail
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__qualname__#139817