Skip to content

gh-139817: Fix refleak in TypeAliasType(qualname=non_string) #140197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

gh-139817: Fix refleak in TypeAliasType(qualname=non_string) #140197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c46640
gh-139817: Fix refleak in TypeAliasType(qualname=non_string)
encukou Oct 16, 2025
11d3641
Move obtaining module
encukou Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Objects/typevarobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2123,11 +2123,6 @@ typealias_new_impl(PyTypeObject *type, PyObject *name, PyObject *value,
return NULL;
}

PyObject *module = caller();
if (module == NULL) {
return NULL;
}

if (qualname == NULL || qualname == Py_None) {
// If qualname was not set directly, we use name instead.
qualname = name;
Expand All @@ -2138,6 +2133,11 @@ typealias_new_impl(PyTypeObject *type, PyObject *name, PyObject *value,
}
}
Copy link
Member

@efimov-mikhail efimov-mikhail Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it's better to place obtaining of module after qualname related if-block and remove a call of Py_DECREF(module).


PyObject *module = caller();
if (module == NULL) {
return NULL;
}

PyObject *ta = (PyObject *)typealias_alloc(
name, qualname, checked_params, NULL, value, module);
Py_DECREF(module);
Expand Down
Loading