-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
Add explanation for PyBool_Check func in bool.rst
#140536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PyBool_Check func in bool.rst
|
Please don't add |
Okay, I'm so sory. |
ZeroIntensity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is useful. We already say "return true", which usually implies that the opposite is "return false".
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
| Return true if *o* is of type :c:data:`PyBool_Type`. This function always | ||
| succeeds. | ||
| succeeds and always returns a valid boolean value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand why this comment is necessary, per the previous line, it always succeeds, therefore it returns an integer, which is a valid boolean value, it makes it redundant? Can you please elaborate as to why this is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, maybe your true, It's truely unnecessary. Sory about that, I'll close the PR soon.
📚 Documentation preview 📚: https://cpython-previews--140536.org.readthedocs.build/