Skip to content

gh-93334: Fix homonym edge case in PathFinder.find_spec() #98100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 5, 2025
Merged

gh-93334: Fix homonym edge case in PathFinder.find_spec() #98100

merged 14 commits into from
Sep 5, 2025

Conversation

jacobtylerwalls
Copy link
Contributor

@jacobtylerwalls jacobtylerwalls commented Oct 8, 2022 •
edited
Loading

@jacobtylerwalls
fixup! Fix homonym edge case
7ee7ebe 
double backticks in news entry
@jacobtylerwalls jacobtylerwalls mentioned this pull request Oct 10, 2022
Closed
@bedevere-bot bedevere-bot mentioned this pull request Apr 8, 2023
Closed
@brettcannon brettcannon changed the title gh-93334: Fix homonym edge case in PathFinder.find_spec gh-93334: Fix homonym edge case in PathFinder.find_spec() Jul 10, 2024
brettcannon
brettcannon requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code should raise ModuleNotFoundError and consider this bug being found due to an invalid call to find_spec when the parent package wasn't imported.

@bedevere-app
Copy link

bedevere-app bot commented Jul 10, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@jacobtylerwalls
Copy link
Contributor Author

I have made the requested changes; please review again

(happy to continue adjusting the test setup to be more minimal, if there's a way)

@bedevere-app
Copy link

bedevere-app bot commented Jul 26, 2024

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

brettcannon
brettcannon requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in getting to this review! Just a tightening of the test and then I think we are good!

@bedevere-app
Copy link

bedevere-app bot commented Sep 13, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@jacobtylerwalls
Copy link
Contributor Author

Thanks for the review! I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Sep 15, 2024

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from brettcannon September 15, 2024 13:42
@jacobtylerwalls jacobtylerwalls mentioned this pull request Nov 22, 2024
Merged
6 tasks
@brettcannon brettcannon self-assigned this Sep 5, 2025
@brettcannon brettcannon merged commit 92b2a8a into python:main Sep 5, 2025
48 of 49 checks passed
@brettcannon
Copy link
Member

@jacobtylerwalls sorry about the extreme delay in reviewing this! 😅 And thanks for the PR!

lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@jacobtylerwalls @lkollar
pythongh-93334: Fix homonym edge case in PathFinder.find_spec() (pyth…
4cdc238 
…onGH-98100)
@jacobtylerwalls jacobtylerwalls deleted the homonym-find-spec branch September 21, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

@brettcannon brettcannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PathFinder.find_spec() can raise bare KeyError when path=None

3 participants

@jacobtylerwalls @brettcannon @bedevere-bot