-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-93334: Fix homonym edge case in PathFinder.find_spec() #98100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
17ddcd0
gh-93334: Fix homonym edge case in PathFinder.find_spec
jacobtylerwalls 7ee7ebe
fixup! Fix homonym edge case
jacobtylerwalls ef08ec0
Merge branch 'main' into homonym-find-spec
jacobtylerwalls c525fb0
Merge branch 'main' into homonym-find-spec
jacobtylerwalls 8092f01
Update expected result
jacobtylerwalls d0f5a82
Fix expected result
jacobtylerwalls 78a1232
fix failing test
jacobtylerwalls efb61c1
reuse string
jacobtylerwalls 1369c60
Merge branch 'main' into homonym-find-spec
jacobtylerwalls 7b77fac
Raise ModuleNotFoundError, update news and tests
jacobtylerwalls 1d59e5c
Let build know about new test package
jacobtylerwalls 3910d92
Merge branch 'main' into homonym-find-spec
brettcannon fd24f87
Address review
jacobtylerwalls 5a8fafb
Merge branch 'main' into homonym-find-spec
brettcannon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
This directory should not be a package, but should share a name with an | ||
brettcannon marked this conversation as resolved.
Show resolved
Hide resolved
|
||
unrelated subpackage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
attr = 'homonym' | ||
brettcannon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2022-10-08-14-56-07.gh-issue-93334.0KUm8d.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Prevent :exc:`KeyError` thrown by :meth:`importlib.machinery.PathFinder.find_spec` | ||
when a directory that is not a module shares a name with a namespace package | ||
submodule, and where a ``path`` argument is not provided. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.