Skip to content

Fix --package-root tests for Windows and Python 3.13+ #19583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025
Merged

Fix --package-root tests for Windows and Python 3.13+ #19583

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85ec0a7
Fix --package-root tests for Windows 3.13
emmatyping Aug 4, 2025
6c87cf8
Slightly different approach
emmatyping Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mypy/fscache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,12 @@ def init_under_package_root(self, path: str) -> bool:
if not stat.S_ISDIR(st.st_mode):
return False
ok = False
drive, path = os.path.splitdrive(path) # Ignore Windows drive name

# skip if on a different drive
current_drive, _ = os.path.splitdrive(os.getcwd())
drive, _ = os.path.splitdrive(path)
if drive != current_drive:
return False
if os.path.isabs(path):
path = os.path.relpath(path)
path = os.path.normpath(path)
Expand Down
Loading