extend mxfp8 roofline with more recipes #3190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuzo
added a commit
that referenced
this pull request
Oct 16, 2025
Summary: Adds: 1. mxfp8_32x32_flexible_gemm_layout (needs gemm kernels and square blocks) 2. mxfp8_32x32_weight (needs square blocks for only weight) Test Plan: ```bash python benchmarks/float8/float8_roofline.py ~/local/tmp/20251016_mxfp8_32x32_weight.csv --mx_recipe_name mxfp8_32x32_weight --do_benchmarks False --shape_gen_name pow2_extended ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 3afb565 ghstack-comment-id: 3411251781 Pull-Request: #3190
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3190
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5bd4e3b with merge base a9694a5 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
vkuzo
added
the
topic: not user facing
drisspg
reviewed
Oct 16, 2025
drisspg
approved these changes
Oct 16, 2025
vkuzo
added a commit
that referenced
this pull request
Oct 16, 2025
Summary: Adds: 1. mxfp8_32x32_flexible_gemm_layout (needs gemm kernels and square blocks) 2. mxfp8_32x32_weight (needs square blocks for only weight) Test Plan: ```bash python benchmarks/float8/float8_roofline.py ~/local/tmp/20251016_mxfp8_32x32_weight.csv --mx_recipe_name mxfp8_32x32_weight --do_benchmarks False --shape_gen_name pow2_extended ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 23319e2 ghstack-comment-id: 3411251781 Pull-Request: #3190
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds:
blocks)
Test Plan:
python benchmarks/float8/float8_roofline.py ~/local/tmp/20251016_mxfp8_32x32_weight.csv --mx_recipe_name mxfp8_32x32_weight --do_benchmarks False --shape_gen_name pow2_extendedReviewers:
Subscribers:
Tasks:
Tags: