-
Notifications
You must be signed in to change notification settings - Fork 349
add option to save profiling traces in inference roofline script #3196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuzo
added a commit
that referenced
this pull request
Oct 17, 2025
Summary: convenient to analyze differences between roofline and observed tl;dr; of findings: mxfp8 1. need to pre-swizzle weights 2. torch.compile gives us two kernels, will repurpose the manual training kernel for this, will need to add pre-swizzling. Longer term, can see if fbgemm_gpu one is faster. mxfp4 1. need a faster gemm (can use fbgemm_gpu) 2. need a fused activation quant kernel (can use fbgemm_gpu) nvfp4 1. need to speed up existing triton activation quant kernel, currently it doesn't autotune anything so probably some easy wins here. Longer term can also benchmark vs fbgemm_gpu Test Plan: ```bash CUDA_VISIBLE_DEVICES=5 python benchmarks/float8/float8_inference_roofline.py ~/local/tmp/20251016_inference_nvfp4.csv --recipe_name nvfp4 --save_profile_traces True ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: a942de7 ghstack-comment-id: 3413384438 Pull-Request: #3196
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3196
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 438b35e with merge base d1a7fbc ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 17, 2025
danielvegamyhre
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
convenient to analyze differences between roofline and observed
tl;dr; of findings:
mxfp8
training kernel for this, will need to add pre-swizzling. Longer
term, can see if fbgemm_gpu one is faster.
mxfp4
nvfp4
it doesn't autotune anything so probably some easy wins here. Longer
term can also benchmark vs fbgemm_gpu
Test Plan:
CUDA_VISIBLE_DEVICES=5 python benchmarks/float8/float8_inference_roofline.py ~/local/tmp/20251016_inference_nvfp4.csv --recipe_name nvfp4 --save_profile_traces True
Reviewers:
Subscribers:
Tasks:
Tags: