Update on "[build] Add editable mode unittest"

As titled. To do this we need to refactor the arguments being passed
into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh`
`unittest-macos.sh`.

[ghstack-poisoned]

Author: larryliu0820

.ci/scripts/setup-linux.sh

@@ -10,7 +10,7 @@ set -exu
 # shellcheck source=/dev/null
 source "$(dirname "${BASH_SOURCE[0]}")/utils.sh"
 
-parse_args "$@"
+read -r BUILD_TOOL BUILD_MODE EDITABLE < <(parse_args "$@")
 
 # As Linux job is running inside a Docker container, all of its dependencies
 # have already been installed, so we use PyTorch build from source here instead

.ci/scripts/setup-macos.sh

@@ -10,7 +10,7 @@ set -exu
 # shellcheck source=/dev/null
 source "$(dirname "${BASH_SOURCE[0]}")/utils.sh"
 
-parse_args "$@"
+read -r BUILD_TOOL BUILD_MODE EDITABLE < <(parse_args "$@")
 
 install_buck() {
   if ! command -v zstd &> /dev/null; then
@@ -130,9 +130,9 @@ install_pytorch_and_domains
 # We build PyTorch from source here instead of using nightly. This allows CI to test against
 # the pinned commit from PyTorch
 if [[ "$EDITABLE" == "true" ]]; then
-  install_executorch "--use-pt-pinned-commit" "--editable"
+  install_executorch --use-pt-pinned-commit --editable
 else
-  install_executorch "--use-pt-pinned-commit"
+  install_executorch --use-pt-pinned-commit
 fi
 build_executorch_runner "${BUILD_TOOL}" "${BUILD_MODE}"
 

.ci/scripts/unittest-linux.sh

@@ -9,7 +9,7 @@ set -eux
 # shellcheck source=/dev/null
 source "$(dirname "${BASH_SOURCE[0]}")/utils.sh"
 
-parse_args "$@"
+read -r BUILD_TOOL BUILD_MODE EDITABLE < <(parse_args "$@")
 
 # The generic Linux job chooses to use base env, not the one setup by the image
 eval "$(conda shell.bash hook)"

.ci/scripts/unittest-macos.sh

@@ -9,7 +9,7 @@ set -eux
 # shellcheck source=/dev/null
 source "$(dirname "${BASH_SOURCE[0]}")/utils.sh"
 
-parse_args "$@"
+read -r BUILD_TOOL BUILD_MODE EDITABLE < <(parse_args "$@")
 
 bash .ci/scripts/setup-conda.sh
 eval "$(conda shell.bash hook)"

.ci/scripts/utils.sh

@@ -191,31 +191,23 @@ parse_args() {
     esac
   done
 
-  if [[ $BUILD_TOOL =~ ^(cmake|buck2)$ ]]; then
-    echo "Build tool is ${BUILD_TOOL} ..."
-  elif [ -z "$BUILD_TOOL" ]; then
+  if [ -z "$BUILD_TOOL" ]; then
     echo "Missing build tool (require buck2 or cmake), exiting..."
     exit 1
-  else
+  elif ! [[ $BUILD_TOOL =~ ^(cmake|buck2)$ ]]; then
     echo "Require buck2 or cmake for --build-tool, got ${BUILD_TOOL}, exiting..."
     exit 1
   fi
   BUILD_MODE="${BUILD_MODE:-Release}"
-  if [[ "$BUILD_MODE" =~ ^(Debug|Release)$ ]]; then
-    echo "Running tests in build mode ${BUILD_MODE} ..."
-  else
+  if ! [[ "$BUILD_MODE" =~ ^(Debug|Release)$ ]]; then
     echo "Unsupported build mode ${BUILD_MODE}, options are Debug or Release."
     exit 1
   fi
   EDITABLE="${EDITABLE:-false}"
-  if [[ $EDITABLE =~ ^(true|false)$ ]]; then
-    echo "Editable mode is ${EDITABLE} ..."
-  else
+  if ! [[ $EDITABLE =~ ^(true|false)$ ]]; then
     echo "Require true or false for --editable, got ${EDITABLE}, exiting..."
     exit 1
   fi
 
-  echo "BUILD_TOOL=$BUILD_TOOL"
-  echo "BUILD_MODE=$BUILD_MODE"
-  echo "EDITABLE=$EDITABLE"
+  echo "$BUILD_TOOL $BUILD_MODE $EDITABLE"
 }