Skip to content

Conversation

@perheld
Copy link
Collaborator

@perheld perheld commented Apr 28, 2025

Bump core_platform to a newer version that includes the patch moving .rodata into DDR thus making the patch reduntant.

But, lurking inside that patch was a add of .got into DDR section so that needs its own patch to be handled.

Once the 0001 patch was fixed the 0002 patch needed some updates.

Change-Id: I453376b8ac8e05005983d15589ab8e42d3c7e0db

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@perheld perheld requested a review from digantdesai as a code owner April 28, 2025 13:17
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10514

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 39adb26 with merge base eb5fc61 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2025
Bump core_platform to a newer version that includes the patch moving
.rodata into DDR thus making the patch reduntant.

But, lurking inside that patch was a add of .got into DDR section so
that needs its own patch to be handled.

Once the 0001 patch was fixed the 0002 patch needed some updates.

Change-Id: I453376b8ac8e05005983d15589ab8e42d3c7e0db
@perheld perheld force-pushed the upstream/ph-bump-core_platform branch from de9855e to 39adb26 Compare April 28, 2025 13:18
@perheld perheld added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Apr 28, 2025
@zingo
Copy link
Collaborator

zingo commented Apr 29, 2025

lint error unrelated

@zingo zingo merged commit 4236e5b into pytorch:main Apr 29, 2025
174 of 176 checks passed
@perheld perheld deleted the upstream/ph-bump-core_platform branch September 2, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants