Allow removing permute pairs in addition to transpose pairs (#10501) #10566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10566
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 PendingAs of commit 9bb90da with merge base b2eac7d ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
force-pushed
the
export-D73619452
branch
from
e2a203e to
161df21
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
force-pushed
the
export-D73619452
branch
from
161df21 to
543756a
Compare
mcremon-meta
force-pushed
the
export-D73619452
branch
from
543756a to
f3c11ea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
force-pushed
the
export-D73619452
branch
from
f3c11ea to
bce6034
Compare
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
force-pushed
the
export-D73619452
branch
from
bce6034 to
7d45fa9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
force-pushed
the
export-D73619452
branch
2 times, most recently
from
8713ed1 to
6e13b20
Compare
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
force-pushed
the
export-D73619452
branch
2 times, most recently
from
6d160c6 to
8553353
Compare
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
force-pushed
the
export-D73619452
branch
from
8553353 to
c4a4141
Compare
mcremon-meta
pushed a commit
to mcremon-meta/executorch-1
that referenced
this pull request
Apr 30, 2025
…10566) Summary: Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
mcremon-meta
force-pushed
the
export-D73619452
branch
from
c4a4141 to
a671e21
Compare
…10566) Summary: Pull Request resolved: pytorch#10566 Pull Request resolved: pytorch#10501 Pull Request resolved: As titled. Gets us 27% better cycles on Activity Classification (at opt level 3). Can be improved further (when fused permutations are not an identity), task is T222295719 Reviewed By: hsharma35 Differential Revision: D73619452
|
This pull request was exported from Phabricator. Differential Revision: D73619452 |
mcremon-meta
force-pushed
the
export-D73619452
branch
from
a671e21 to
9bb90da
Compare
hsharma35
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved:
As titled. Gets us 27% better cycles on Activity Classification (at opt level 3).
Can be improved further (when fused permutations are not an identity), task is T222295719
Differential Revision: D73619452