-
Notifications
You must be signed in to change notification settings - Fork 705
[ET-VK] Removing descriptor pool intialization from DescriptorPool ctor. #10777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/trivedivivek/83/base
Are you sure you want to change the base?
Conversation
Descriptor pool is initialized with proper capacity while ComputeGraph is build, in ComputeGraph::prepare function. Thus, initializing descriptor pool in constructor just add throwaway work. Differential Revision: [D74347030](https://our.internmc.facebook.com/intern/diff/D74347030/) [ghstack-poisoned]
Descriptor pool is initialized with proper capacity while ComputeGraph is build, in ComputeGraph::prepare function. Thus, initializing descriptor pool in constructor just add throwaway work. Differential Revision: [D74347030](https://our.internmc.facebook.com/intern/diff/D74347030/) ghstack-source-id: 282829408 Pull Request resolved: #10777
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10777
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New FailuresAs of commit fb621e6 with merge base 277c39d ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D74347030 |
…ptorPool ctor." Descriptor pool is initialized with proper capacity while ComputeGraph is build, in ComputeGraph::prepare function. Thus, initializing descriptor pool in constructor just add throwaway work. Differential Revision: [D74347030](https://our.internmc.facebook.com/intern/diff/D74347030/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D74347030 |
Pull Request resolved: pytorch/executorch#10777 Descriptor pool is initialized with proper capacity while ComputeGraph is build, in ComputeGraph::prepare function. Thus, initializing descriptor pool in constructor just add throwaway work. Differential Revision: [D74347030](https://our.internmc.facebook.com/intern/diff/D74347030/) ghstack-source-id: 283034826
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack (oldest at bottom):
Descriptor pool is initialized with proper capacity while ComputeGraph is build, in ComputeGraph::prepare function.
Thus, initializing descriptor pool in constructor just add throwaway work.
Differential Revision: D74347030