Arm backend: Fix ensures check in UnsqueezeScalarPlaceholdersPass #10811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In UnsqueezeScalarPlaceholdersPass, only the placeholders that meet certain conditions will be unsqueezed. Otherwise, they retain their original shape. This patch adds a new check to ensure that placeholders that don't meet the conditions should be skipped Change-Id: I9d348dff607f04f2dd28d2b9ef744c1bda410f5d Signed-off-by: Yufeng Shi <[email protected]>
YufengShi-dudu
requested review from
AdrianLundell,
ArmRyan,
Erik-Lundell and
mansnils
YufengShi-dudu
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10811
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a9e4cdb with merge base b173722 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
ArmRyan
approved these changes
May 12, 2025
Collaborator
Author
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I9d348dff607f04f2dd28d2b9ef744c1bda410f5d
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218