Skip to content

Arm backend: Fix ensures check in UnsqueezeScalarPlaceholdersPass #10811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

Arm backend: Fix ensures check in UnsqueezeScalarPlaceholdersPass #10811

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a6cefd
Arm backend: Fix ensures check in UnsqueezeScalarPlaceholdersPass
YufengShi-dudu Apr 8, 2025
a9e4cdb
Merge branch 'main' into fix-unsqueeze-scalar-placeholder-pass
YufengShi-dudu May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions backends/arm/_passes/unsqueeze_scalar_placeholders_pass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# Copyright 2024 Arm Limited and/or its affiliates.
# All rights reserved.
# Copyright 2024-2025 Arm Limited and/or its affiliates.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.
Expand All @@ -20,17 +19,19 @@ def __init__(self, exported_program):
self.exported_program = exported_program
super().__init__()

def _is_inputs_to_buffers_or_parameters(self, node):
return (
node.name in self.exported_program.graph_signature.inputs_to_buffers
or node.name in self.exported_program.graph_signature.inputs_to_parameters
)

def call(self, graph_module: torch.fx.GraphModule):
for node in graph_module.graph.nodes:
if node.op != "placeholder":
continue
rank = node.meta["val"].dim()
if rank == 0:
if not (
node.name in self.exported_program.graph_signature.inputs_to_buffers
or node.name
in self.exported_program.graph_signature.inputs_to_parameters
):
if not self._is_inputs_to_buffers_or_parameters(node):
continue
tensor = self.exported_program.state_dict[node.name]
if tensor.dim() == 0:
Expand All @@ -52,4 +53,6 @@ def ensures(self, graph_module: torch.fx.GraphModule):
if node.op == "placeholder":
rank = node.meta["val"].dim()
if rank == 0:
if not self._is_inputs_to_buffers_or_parameters(node):
continue
raise ValueError("Placeholders of rank 0 are not supported!")
Loading