Skip to content

Conversation

@larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented May 21, 2025

Stack from ghstack (oldest at bottom):

Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.

Test Plan: Rely on CI jobs.

Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.

Test Plan: Rely on CI jobs.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented May 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11052

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit e2e330d with merge base d892b66 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

larryliu0820 added a commit that referenced this pull request May 21, 2025
Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.

Test Plan: Rely on CI jobs.

ghstack-source-id: 4f38ada
Pull Request resolved: #11052
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2025
@larryliu0820 larryliu0820 added the release notes: llm Changes to llm utilities label May 21, 2025
-DEXECUTORCH_BUILD_XNNPACK="$XNNPACK" \
-DEXECUTORCH_BUILD_MPS="$MPS" \
-DEXECUTORCH_BUILD_COREML="$COREML" \
retry cmake --preset llm \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's beautiful 🥹

Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.

Test Plan: Rely on CI jobs.

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request May 21, 2025
Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.

Test Plan: Rely on CI jobs.

ghstack-source-id: 9909f9f
Pull Request resolved: #11052
Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.

Test Plan: Rely on CI jobs.

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request May 22, 2025
Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.

Test Plan: Rely on CI jobs.

ghstack-source-id: 8e3b2d2
Pull Request resolved: #11052
Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.

Test Plan: Rely on CI jobs.

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request May 22, 2025
Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.

Test Plan: Rely on CI jobs.

ghstack-source-id: 06063f0
Pull Request resolved: #11052
Copy link
Contributor

@jathu jathu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!!

rm -rf cmake-out
retry cmake \
retry cmake --preset llm \
-DCMAKE_INSTALL_PREFIX=cmake-out \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be deleted too, since it's the default

Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.

Test Plan: Rely on CI jobs.

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request May 22, 2025
Summary: By default turn on custom ops, optimized kernels, xnnpack. For
macOS/iOS turn on coreml and MPS.

Test Plan: Rely on CI jobs.

ghstack-source-id: d67e59b
Pull Request resolved: #11052
@larryliu0820 larryliu0820 merged commit a36e122 into gh/larryliu0820/64/base May 22, 2025
190 of 192 checks passed
@larryliu0820 larryliu0820 deleted the gh/larryliu0820/64/head branch May 22, 2025 07:25
larryliu0820 added a commit that referenced this pull request May 22, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #11052 by
@larryliu0820
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/larryliu0820/64/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/larryliu0820/64/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/larryliu0820/64/orig
@diff-train-skip-merge

Co-authored-by: Mengwei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: llm Changes to llm utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants