- 
                Notifications
    
You must be signed in to change notification settings  - Fork 712
 
Add CMake preset for LLM #11052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            larryliu0820
  merged 5 commits into
  gh/larryliu0820/64/base
from
gh/larryliu0820/64/head
  
      
      
   
  May 22, 2025 
      
    
  
     Merged
                    Add CMake preset for LLM #11052
Changes from 4 commits
      Commits
    
    
            Show all changes
          
          
            5 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      4623457
              
                Add CMake preset for LLM
              
              
                larryliu0820 07f837f
              
                Update on "Add CMake preset for LLM"
              
              
                larryliu0820 3ddea49
              
                Update on "Add CMake preset for LLM"
              
              
                larryliu0820 5ee53a4
              
                Update on "Add CMake preset for LLM"
              
              
                larryliu0820 e2e330d
              
                Update on "Add CMake preset for LLM"
              
              
                larryliu0820 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -152,21 +152,11 @@ which "${PYTHON_EXECUTABLE}" | |
| cmake_install_executorch_libraries() { | ||
| echo "Installing libexecutorch.a, libextension_module.so, libportable_ops_lib.a" | ||
| rm -rf cmake-out | ||
| retry cmake \ | ||
| retry cmake --preset llm \ | ||
| -DCMAKE_INSTALL_PREFIX=cmake-out \ | ||
| 
         There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be deleted too, since it's the default  | 
||
| -DCMAKE_BUILD_TYPE="$CMAKE_BUILD_TYPE" \ | ||
| -DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \ | ||
| -DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \ | ||
| -DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \ | ||
| -DEXECUTORCH_BUILD_KERNELS_CUSTOM="$CUSTOM" \ | ||
| -DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \ | ||
| -DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON \ | ||
| -DEXECUTORCH_BUILD_XNNPACK="$XNNPACK" \ | ||
| -DEXECUTORCH_BUILD_MPS="$MPS" \ | ||
| -DEXECUTORCH_BUILD_COREML="$COREML" \ | ||
| -DEXECUTORCH_BUILD_QNN="$QNN" \ | ||
                
      
                  jathu marked this conversation as resolved.
               
          
            Show resolved
            Hide resolved
         | 
||
| -DQNN_SDK_ROOT="$QNN_SDK_ROOT" \ | ||
| -DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \ | ||
| -Bcmake-out . | ||
| cmake --build cmake-out -j9 --target install --config "$CMAKE_BUILD_TYPE" | ||
| } | ||
| 
        
          
        
         | 
    @@ -181,10 +171,6 @@ cmake_build_llama_runner() { | |
| retry cmake \ | ||
| -DCMAKE_INSTALL_PREFIX=cmake-out \ | ||
| -DCMAKE_BUILD_TYPE="$CMAKE_BUILD_TYPE" \ | ||
| -DEXECUTORCH_BUILD_KERNELS_CUSTOM="$CUSTOM" \ | ||
| -DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \ | ||
| -DEXECUTORCH_BUILD_XNNPACK="$XNNPACK" \ | ||
| -DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \ | ||
| -Bcmake-out/${dir} \ | ||
| ${dir} | ||
| cmake --build cmake-out/${dir} -j9 --config "$CMAKE_BUILD_TYPE" | ||
| 
          
            
          
           | 
    ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| # All rights reserved. | ||
| # | ||
| # This source code is licensed under the BSD-style license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
| 
     | 
||
| # Enable logging even when in release mode. We are building for desktop, where | ||
| # saving a few kB is less important than showing useful error information to | ||
| # users. | ||
| # keep sorted | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_DATA_LOADER ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_MODULE ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_TENSOR ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_KERNELS_CUSTOM ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_KERNELS_OPTIMIZED ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_KERNELS_QUANTIZED ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_XNNPACK ON) | ||
| 
     | 
||
| if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") | ||
| set_overridable_option(EXECUTORCH_BUILD_COREML ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_MPS ON) | ||
| elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux") | ||
| # Linux-specific code here | ||
| elseif(CMAKE_SYSTEM_NAME STREQUAL "Windows" OR CMAKE_SYSTEM_NAME STREQUAL "WIN32") | ||
| # Windows or other OS-specific code here | ||
| elseif(CMAKE_SYSTEM_NAME STREQUAL "Android") | ||
| # Android-specific code here | ||
| else() | ||
| message(FATAL_ERROR "Unsupported CMAKE_SYSTEM_NAME for LLM: ${CMAKE_SYSTEM_NAME}") | ||
| endif() | 
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's beautiful 🥹