[ET-VK] Tuning conv 2d pw op tile size to improve perf. #11112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff tunes the tile size for the conv 2d pw op to improve performance. The changes include updating the `TILE_SIZE_X` and `TILE_SIZE_Y` values in the `conv2d_pw.yaml` files and modifying the `Convolution.cpp` files to adjust the image extents calculation. The `TILE_SIZE_X` value is changed from 2 to 1, and the `TILE_SIZE_Y` value is changed from 2 to 4. Differential Revision: [D75317820](https://our.internmc.facebook.com/intern/diff/D75317820/) [ghstack-poisoned]
This was referenced May 23, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11112
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 767d018 with merge base 380eb5f ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
trivedivivek
added a commit
that referenced
this pull request
May 23, 2025
This diff tunes the tile size for the conv 2d pw op to improve performance. The changes include updating the `TILE_SIZE_X` and `TILE_SIZE_Y` values in the `conv2d_pw.yaml` files and modifying the `Convolution.cpp` files to adjust the image extents calculation. The `TILE_SIZE_X` value is changed from 2 to 1, and the `TILE_SIZE_Y` value is changed from 2 to 4. Differential Revision: [D75317820](https://our.internmc.facebook.com/intern/diff/D75317820/) ghstack-source-id: 285956546 Pull Request resolved: #11112
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75317820 |
This diff tunes the tile size for the conv 2d pw op to improve performance. The changes include updating the `TILE_SIZE_X` and `TILE_SIZE_Y` values in the `conv2d_pw.yaml` files and modifying the `Convolution.cpp` files to adjust the image extents calculation. The `TILE_SIZE_X` value is changed from 2 to 1, and the `TILE_SIZE_Y` value is changed from 2 to 4. Differential Revision: [D75317820](https://our.internmc.facebook.com/intern/diff/D75317820/) [ghstack-poisoned]
This was referenced May 27, 2025
|
This pull request was exported from Phabricator. Differential Revision: D75317820 |
This diff tunes the tile size for the conv 2d pw op to improve performance. The changes include updating the `TILE_SIZE_X` and `TILE_SIZE_Y` values in the `conv2d_pw.yaml` files and modifying the `Convolution.cpp` files to adjust the image extents calculation. The `TILE_SIZE_X` value is changed from 2 to 1, and the `TILE_SIZE_Y` value is changed from 2 to 4. Differential Revision: [D75317820](https://our.internmc.facebook.com/intern/diff/D75317820/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75317820 |
SS-JIA
approved these changes
May 27, 2025
This diff tunes the tile size for the conv 2d pw op to improve performance. The changes include updating the `TILE_SIZE_X` and `TILE_SIZE_Y` values in the `conv2d_pw.yaml` files and modifying the `Convolution.cpp` files to adjust the image extents calculation. The `TILE_SIZE_X` value is changed from 2 to 1, and the `TILE_SIZE_Y` value is changed from 2 to 4. Differential Revision: [D75317820](https://our.internmc.facebook.com/intern/diff/D75317820/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75317820 |
trivedivivek
added
the
release notes: none
This diff tunes the tile size for the conv 2d pw op to improve performance. The changes include updating the `TILE_SIZE_X` and `TILE_SIZE_Y` values in the `conv2d_pw.yaml` files and modifying the `Convolution.cpp` files to adjust the image extents calculation. The `TILE_SIZE_X` value is changed from 2 to 1, and the `TILE_SIZE_Y` value is changed from 2 to 4. Differential Revision: [D75317820](https://our.internmc.facebook.com/intern/diff/D75317820/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75317820 |
This diff tunes the tile size for the conv 2d pw op to improve performance. The changes include updating the `TILE_SIZE_X` and `TILE_SIZE_Y` values in the `conv2d_pw.yaml` files and modifying the `Convolution.cpp` files to adjust the image extents calculation. The `TILE_SIZE_X` value is changed from 2 to 1, and the `TILE_SIZE_Y` value is changed from 2 to 4. Differential Revision: [D75317820](https://our.internmc.facebook.com/intern/diff/D75317820/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75317820 |
This diff tunes the tile size for the conv 2d pw op to improve performance. The changes include updating the `TILE_SIZE_X` and `TILE_SIZE_Y` values in the `conv2d_pw.yaml` files and modifying the `Convolution.cpp` files to adjust the image extents calculation. The `TILE_SIZE_X` value is changed from 2 to 1, and the `TILE_SIZE_Y` value is changed from 2 to 4. Differential Revision: [D75317820](https://our.internmc.facebook.com/intern/diff/D75317820/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75317820 |
facebook-github-bot
merged commit 8b7e4fe
into
gh/trivedivivek/91/base
94 of 98 checks passed
facebook-github-bot
had a problem deploying
to
cherry-pick-bot
GitHub Actions
Failure
trivedivivek
added a commit
that referenced
this pull request
May 28, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11112 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/91/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/91/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/90/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/91/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff tunes the tile size for the conv 2d pw op to improve performance. The changes include updating the
TILE_SIZE_XandTILE_SIZE_Yvalues in theconv2d_pw.yamlfiles and modifying theConvolution.cppfiles to adjust the image extents calculation. TheTILE_SIZE_Xvalue is changed from 2 to 1, and theTILE_SIZE_Yvalue is changed from 2 to 4.Differential Revision: D75317820