Skip to content

[ET-VK] Tuning conv 2d pw op tile size to improve perf. #11112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025
Merged

[ET-VK] Tuning conv 2d pw op tile size to improve perf. #11112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
790057a
[ET-VK] Tuning conv 2d pw op tile size to improve perf.
trivedivivek May 23, 2025
ff3277f
Update on "[ET-VK] Tuning conv 2d pw op tile size to improve perf."
trivedivivek May 27, 2025
eed5854
Update on "[ET-VK] Tuning conv 2d pw op tile size to improve perf."
trivedivivek May 27, 2025
21af8ba
Update on "[ET-VK] Tuning conv 2d pw op tile size to improve perf."
trivedivivek May 27, 2025
8b1b53d
Update on "[ET-VK] Tuning conv 2d pw op tile size to improve perf."
trivedivivek May 28, 2025
a1e9dab
Update on "[ET-VK] Tuning conv 2d pw op tile size to improve perf."
trivedivivek May 28, 2025
767d018
Update on "[ET-VK] Tuning conv 2d pw op tile size to improve perf."
trivedivivek May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backends/vulkan/runtime/graph/ops/glsl/conv2d_pw.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ conv2d_pw:
OPERATOR: X
NDIM: 3
DTYPE: float
TILE_SIZE_X: 2
TILE_SIZE_Y: 2
TILE_SIZE_X: 1
TILE_SIZE_Y: 4
generate_variant_forall:
DTYPE:
- VALUE: half
Expand Down
4 changes: 2 additions & 2 deletions backends/vulkan/runtime/graph/ops/impl/Convolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,8 @@ utils::uvec3 create_conv2d_global_wg_size(
if (method == Conv2dMethod::Pointwise) {
const utils::uvec3 image_extents = graph.logical_limits_of(out);
return {
utils::div_up(image_extents[0u], 2u),
utils::div_up(image_extents[1u], 2u),
utils::div_up(image_extents[0u], 1u),
utils::div_up(image_extents[1u], 4u),
image_extents[2u]};
} else if (method == Conv2dMethod::Depthwise && stride_equals_dilation) {
const utils::uvec3 image_extents = graph.create_global_wg_size(out);
Expand Down
Loading