Android preset #11119
Android preset #11119
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11119
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 256c5ac with merge base 410989a ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
| -DCMAKE_TOOLCHAIN_FILE="${ANDROID_NDK}/build/cmake/android.toolchain.cmake" \ | ||
| -DANDROID_ABI="${ANDROID_ABI}" \ | ||
| --preset "android-${ANDROID_ABI}" \ | ||
| -DANDROID_PLATFORM=android-26 \ |
There was a problem hiding this comment.
Can you add this to preset as well?
There was a problem hiding this comment.
We need to build twice, one for x86_64, one for arm64-v8a.
There was a problem hiding this comment.
I think you can set one as default and override another one
CMakePresets.json
Outdated
| }, | ||
| { | ||
| "name": "android-arm64-v8a", | ||
| "displayName": "Build everything buildable on android arm64-v8a", |
There was a problem hiding this comment.
This doesn't sound accurate right? Could be "Build executorch core and JNI bindings on android arm64-v8a"?
|
Can you add a CI job for android preset? Also cc @jathu if you are interested. |
Not for our preset test series. We are using a separate sh to build it right now and always using this preset anyway so we don't really want the preset specific test. |
scripts/build_android_library.sh
Outdated
| -DEXECUTORCH_BUILD_DEVTOOLS=ON \ | ||
| -DEXECUTORCH_ENABLE_EVENT_TRACER="${EXECUTORCH_ANDROID_PROFILING:-OFF}" \ | ||
| -DEXECUTORCH_LOG_LEVEL=Info \ | ||
| -DEXECUTORCH_BUILD_XNNPACK=ON \ | ||
| -DEXECUTORCH_XNNPACK_SHARED_WORKSPACE=ON \ | ||
| -DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \ | ||
| -DEXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR=ON \ | ||
| -DEXECUTORCH_BUILD_EXTENSION_LLM="${EXECUTORCH_BUILD_EXTENSION_LLM:-ON}" \ | ||
| -DEXECUTORCH_BUILD_EXTENSION_LLM_RUNNER="${EXECUTORCH_BUILD_EXTENSION_LLM:-ON}" \ | ||
| -DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \ | ||
| -DEXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL=ON \ | ||
| -DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \ | ||
| -DEXECUTORCH_BUILD_EXTENSION_TRAINING=ON \ | ||
| -DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \ | ||
| -DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON \ | ||
| -DEXECUTORCH_BUILD_KERNELS_LLM="${EXECUTORCH_BUILD_EXTENSION_LLM:-ON}" \ | ||
| -DEXECUTORCH_BUILD_LLAMA_JNI="${EXECUTORCH_BUILD_EXTENSION_LLM:-ON}" \ | ||
| -DEXECUTORCH_BUILD_NEURON="${EXECUTORCH_BUILD_NEURON}" \ | ||
| -DNEURON_BUFFER_ALLOCATOR_LIB="${NEURON_BUFFER_ALLOCATOR_LIB}" \ |
There was a problem hiding this comment.
Can't we remove all the options? i.e. EXECUTORCH_BUILD_DEVTOOLS is still there
No description provided.