-
Notifications
You must be signed in to change notification settings - Fork 741
Android preset #11119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Android preset #11119
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
20634a2
android preset
kirklandsign 4acacfd
Use normal cmake-out
kirklandsign 71b062e
Fix
kirklandsign 522e8b0
Merge remote-tracking branch 'origin/main' into android-preset
kirklandsign cb8d055
Update flags
kirklandsign 2db2bef
don't test yet
kirklandsign f10c831
Merge remote-tracking branch 'origin/main' into android-preset
kirklandsign dba1337
Update
kirklandsign f1e02c1
Merge remote-tracking branch 'origin/main' into android-preset
kirklandsign 3866941
Update
kirklandsign f520003
Merge branch 'main' into android-preset
kirklandsign ad8c7cc
AO OFF
kirklandsign ab82fb9
Merge remote-tracking branch 'refs/remotes/origin/android-preset' int…
kirklandsign bf29bf8
Comment fix
kirklandsign a974109
Merge remote-tracking branch 'origin/main' into android-preset
kirklandsign 8cea9a3
Remove devtools
kirklandsign 256c5ac
Merge branch 'main' into android-preset
kirklandsign File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| # All rights reserved. | ||
| # | ||
| # This source code is licensed under the BSD-style license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
|
|
||
| set_overridable_option(BUILD_TESTING OFF) | ||
|
|
||
| set_overridable_option(EXECUTORCH_BUILD_ANDROID_JNI ON) | ||
| set_overridable_option(EXECUTORCH_PAL_DEFAULT android) | ||
| set_overridable_option(EXECUTORCH_ENABLE_EVENT_TRACER OFF) | ||
| set_overridable_option(EXECUTORCH_ENABLE_LOGGING ON) | ||
| set_overridable_option(EXECUTORCH_LOG_LEVEL Info) | ||
|
|
||
| set_overridable_option(EXECUTORCH_BUILD_DEVTOOLS ON) | ||
|
|
||
| set_overridable_option(EXECUTORCH_BUILD_XNNPACK ON) | ||
| set_overridable_option(EXECUTORCH_XNNPACK_SHARED_WORKSPACE ON) | ||
|
|
||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_DATA_LOADER ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_LLM ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_LLM_RUNNER ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_MODULE ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_TENSOR ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_EXTENSION_TRAINING ON) | ||
|
|
||
| set_overridable_option(EXECUTORCH_BUILD_KERNELS_LLM ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_KERNELS_OPTIMIZED ON) | ||
| set_overridable_option(EXECUTORCH_BUILD_KERNELS_QUANTIZED ON) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this to preset as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to build twice, one for x86_64, one for arm64-v8a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can set one as default and override another one