Skip to content

[ET-VK][Ops] quantize_per_token.default test setup #11367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 14, 2025
Merged

[ET-VK][Ops] quantize_per_token.default test setup #11367

merged 14 commits into from
Jun 14, 2025

Conversation

@ahmtox
Copy link
Contributor

@ahmtox ahmtox commented Jun 4, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: D75607854

[ET-VK][Ops] quantize_per_token.default test setup
e9a861a 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@ahmtox ahmtox requested a review from SS-JIA as a code owner June 4, 2025 18:03
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11367

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit 5b51132 with merge base 8cfa858 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jun 4, 2025
Merged
Merged
Merged
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
88cd976 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
This was referenced Jun 9, 2025
Merged
Merged
Merged
Merged
Merged
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
c208857 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
633058d 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
This was referenced Jun 11, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

manuelcandales
manuelcandales requested changes Jun 11, 2025
View reviewed changes
backends/vulkan/test/op_tests/quantize_test.cpp

TEST(
VulkanQuantizePerTensorTest,
test_reference_quantize_per_token_float_to_int8) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests where the input is half, and also where the output is uint8 or int32 (supported dtypes IIUC)

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
2c4b6f5 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

@ahmtox ahmtox added the release notes: vulkan Changes to the Vulkan backend delegate label Jun 11, 2025
Update on "[ET-VK][Ops] quantize_per_token.default test setup"
d3e58d4 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@ahmtox ahmtox mentioned this pull request Jun 11, 2025
Merged
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
3ea58f4 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
06e3ea1 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
3edd2d8 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
76d1407 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
6634f94 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
24306b1 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
0babc8f 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

Update on "[ET-VK][Ops] quantize_per_token.default test setup"
5b51132 
Creating quantize_per_token testing framework along with a reference implementation for testing

Differential Revision: [D75607854](https://our.internmc.facebook.com/intern/diff/D75607854/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75607854

@facebook-github-bot facebook-github-bot merged commit 999044f into gh/ahmtox/9/base Jun 14, 2025
95 of 98 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/ahmtox/9/head branch June 14, 2025 03:46
@pytorchbot pytorchbot mentioned this pull request Jun 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

@manuelcandales manuelcandales manuelcandales approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahmtox @facebook-github-bot @SS-JIA @manuelcandales