[ET-VK][Ops] choose_qparams_per_token_asymmetric.default test setup #11556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11556
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 9a2ace2 with merge base 8cfa858 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 9, 2025
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76436906 |
…est setup" Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76436906 |
…est setup" Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76436906 |
…est setup" Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76436906 |
…est setup" Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76436906 |
…est setup" Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76436906 |
…est setup" Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76436906 |
SS-JIA
approved these changes
Jun 12, 2025
…est setup" Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76436906 |
…est setup" Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76436906 |
…est setup" Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76436906 |
…est setup" Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76436906 |
facebook-github-bot
merged commit 35f2d29
into
gh/ahmtox/21/base
91 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#11556 # Context In order to enhance my own understanding of these operators, I needed to create a reference implementation, and also build out the vulkan testing framework which creates the necessary build up when I need to call the vulkan implementations. I won't explain what the choose_qparams operator actually is in this diff, but will rather opt to explain the operator in a future diff where I implement the glsl shader, however, the reference implementation is heavily inspired by the cpu implementation. This diff is the per_token reference implementation. Also this is for the asymmetric version, which has the same quant_min and quant_max all throughout as int8. # Changes The main changes were the include of the reference implementation that is used for my own learning, and the necessary wrapper functions that will be called later when the vulkan implementation is successfully completed. It has everything necessary for this purpose, including calling the operator by its appropriate name as when defined in the C++ implementation header, and staging components correctly from the GPU and then the CPU which will be where the comparison is done. I have also included comprehensive failure print statements that prints the tensor size along with relevant parameters. This is for the per_token implementation. ghstack-source-id: 290376495 @exported-using-ghexport Differential Revision: [D76436906](https://our.internmc.facebook.com/intern/diff/D76436906/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Creating choose_qparams_per_token_asymmetric.default operator testing framework along with a reference implementation for testing
Differential Revision: D76436906