solve duplicate dependency issues to unblock pybinding backend migration #11566
Conversation
…block pybinding backend migration This diff creates different namespace for Module and BundledModule under different mode (aten or portable) to hacky solve the duplicated symbol issues in D73564127 since the their are too many complex dependency issues to solve, and lots of users are asking for pybinding backend migration. In the future this impl should be replaced by shim-like layers. Differential Revision: [D76405701](https://our.internmc.facebook.com/intern/diff/D76405701/) [ghstack-poisoned]
Gasoonjia
requested review from
JacobSzwejbka,
larryliu0820 and
shoumikhin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11566
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a16e37e with merge base c4c4763 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
…block pybinding backend migration This diff creates different namespace for Module and BundledModule under different mode (aten or portable) to hacky solve the duplicated symbol issues in D73564127 since the their are too many complex dependency issues to solve, and lots of users are asking for pybinding backend migration. In the future this impl should be replaced by shim-like layers. Differential Revision: [D76405701](https://our.internmc.facebook.com/intern/diff/D76405701/) ghstack-source-id: 289729679 Pull Request resolved: #11566
|
This pull request was exported from Phabricator. Differential Revision: D76405701 |
This PR needs a
|
…ssues to unblock pybinding backend migration" This diff creates different namespace for Module and BundledModule under different mode (aten or portable) to hacky solve the duplicated symbol issues in D73564127 since the their are too many complex dependency issues to solve, and lots of users are asking for pybinding backend migration. In the future this impl should be replaced by shim-like layers. Differential Revision: [D76405701](https://our.internmc.facebook.com/intern/diff/D76405701/) [ghstack-poisoned]
…block pybinding backend migration Pull Request resolved: #11566 This diff creates different namespace for Module and BundledModule under different mode (aten or portable) to hacky solve the duplicated symbol issues in D73564127 since the their are too many complex dependency issues to solve, and lots of users are asking for pybinding backend migration. In the future this impl should be replaced by shim-like layers. Differential Revision: [D76405701](https://our.internmc.facebook.com/intern/diff/D76405701/) ghstack-source-id: 289747055
|
This pull request was exported from Phabricator. Differential Revision: D76405701 |
Gasoonjia
changed the title
|
I vaguely remember a discussion with @swolchok et al. about this hack, did we eventually decide to go with it? Will it be temporary workaround with a timeline to revert when a proper solution is introduced? |
yeah I don't think we should be doing this and I also vaguely recall talking about it previously, but I don't have a reference to the specific previous discussion. |
…kend migration" This diff creates different namespace for Module and BundledModule under different mode (aten or portable) to hacky solve the duplicated symbol issues in D73564127 since the their are too many complex dependency issues to solve, and lots of users are asking for pybinding backend migration. In the future this impl should be replaced by shim-like layers. Differential Revision: [D76405701](https://our.internmc.facebook.com/intern/diff/D76405701/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76405701 |
…kend migration" This diff creates different namespace for Module and BundledModule under different mode (aten or portable) to hacky solve the duplicated symbol issues in D73564127 since the their are too many complex dependency issues to solve, and lots of users are asking for pybinding backend migration. In the future this impl should be replaced by shim-like layers. Differential Revision: [D76405701](https://our.internmc.facebook.com/intern/diff/D76405701/) [ghstack-poisoned]
…block pybinding backend migration Pull Request resolved: #11566 This diff creates different namespace for Module and BundledModule under different mode (aten or portable) to hacky solve the duplicated symbol issues in D73564127 since the their are too many complex dependency issues to solve, and lots of users are asking for pybinding backend migration. In the future this impl should be replaced by shim-like layers. ghstack-source-id: 289776208 Differential Revision: [D76405701](https://our.internmc.facebook.com/intern/diff/D76405701/)
|
This pull request was exported from Phabricator. Differential Revision: D76405701 |
…kend migration" This diff creates different namespace for Module and BundledModule under different mode (aten or portable) to hacky solve the duplicated symbol issues in D73564127 since the their are too many complex dependency issues to solve, and lots of users are asking for pybinding backend migration. In the future this impl should be replaced by shim-like layers. Differential Revision: [D76405701](https://our.internmc.facebook.com/intern/diff/D76405701/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76405701 |
facebook-github-bot
merged commit 48ef48c
into
gh/gasoonjia/14/base
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
…ion (#11594) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11566 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/14/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/14/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/14/orig @diff-train-skip-merge Co-authored-by: gasoonjia <[email protected]>
|
@shoumikhin and @swolchok yes we do have discussion previously and this is sort of a hacky way. But in our codebase there're too much existing targets that depends on both aten and portable mode at the same time and some weird dependency situation we can not solve. So maybe currently we can land it first and then working on some shim-like layer to solve the dependency issue completely. |
Stack from ghstack (oldest at bottom):
PyBundledModulewithextension.BundledModule#11565This diff creates different namespace for Module and BundledModule under different mode (aten or portable) to hacky solve the duplicated symbol issues in D73564127 since the their are too many complex dependency issues to solve, and lots of users are asking for pybinding backend migration.
In the future this impl should be replaced by shim-like layers.
Differential Revision: D76405701