-
Notifications
You must be signed in to change notification settings - Fork 713
Support for Model API for Selective Build in OSS #11601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11601
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 2 Pending, 1 Unrelated FailureAs of commit 76ec14f with merge base 8895573 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "release notes: none" |
This PR needs a
|
lucylq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for adding this!
4e96927 to
095d469
Compare
095d469 to
4fc5fe0
Compare
Ensuring clean build dir when running
Fixing comment
4fc5fe0 to
76ec14f
Compare
Summary
Added support for parsing the selected operators and dtypes directly from an exported model to a
selected_operators.yamlfile. Previously, operators had to be specified in string list or in a schema yaml file for the selective build process. Now, a model can be specified at build time (e.g.-DEXECUTORCH_SELECT_OPS_FROM_MODEL="./mv2.pte") to parse and select operators.Test plan
Added a test for this in
examples/selective_build/test_selective_build.sh. When run withbash examples/selective_build/test_selective_build.sh cmakea resultantselected_operators.yamlfile is created atcmake-out/examples/selective_build/select_build_lib/selected_operators.yamlthat conatins the selected operators as well as their dtypes.