Skip to content

Conversation

@guangy10
Copy link
Contributor

Summary

There is a mandatory flag DEXECUTORCH_BUILD_EXECUTOR_RUNNER must be turned on in order to build executor_runner, but this flag is not explicitly set in our tutorial. Though the default of it is ON, it can still be a UX issue when following the tutorial where the flag was toggled OFF silently when building for other target like llama_runner.

Test plan

CI

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11773

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 4163a7d with merge base 7503bb3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2025
@guangy10 guangy10 requested review from jathu and larryliu0820 June 18, 2025 00:18
@guangy10 guangy10 added the release notes: none Do not include this in the release notes label Jun 18, 2025
@guangy10 guangy10 merged commit 29db57b into main Jun 18, 2025
99 of 104 checks passed
@guangy10 guangy10 deleted the fix_executor_cmake_instructions branch June 18, 2025 18:49
@guangy10 guangy10 added release notes: docs and removed release notes: none Do not include this in the release notes labels Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants