[ET-VK] New Implementation of `permute' operator #11825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes * Introduce `permute_buffer.glsl` and `permute_texture.glsl` compute shader templates to implement the permute operator ## Motivation The existing implementation of permute produced incorrect outputs for width packed textures. Furthermore, there was no buffer implementation for the permute operator. My goal with this diff is to introduce a more flexible implementation of permute that could work for any tensor representation. ## Performance impact None expected. Differential Revision: [D76483755](https://our.internmc.facebook.com/intern/diff/D76483755/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11825
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7759ee1 with merge base 89bdd1d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76483755 |
This PR needs a
|
## Changes * Introduce `permute_buffer.glsl` and `permute_texture.glsl` compute shader templates to implement the permute operator ## Motivation The existing implementation of permute produced incorrect outputs for width packed textures. Furthermore, there was no buffer implementation for the permute operator. My goal with this diff is to introduce a more flexible implementation of permute that could work for any tensor representation. ## Performance impact None expected. Differential Revision: [D76483755](https://our.internmc.facebook.com/intern/diff/D76483755/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76483755 |
## Changes * Introduce `permute_buffer.glsl` and `permute_texture.glsl` compute shader templates to implement the permute operator ## Motivation The existing implementation of permute produced incorrect outputs for width packed textures. Furthermore, there was no buffer implementation for the permute operator. My goal with this diff is to introduce a more flexible implementation of permute that could work for any tensor representation. ## Performance impact None expected. Differential Revision: [D76483755](https://our.internmc.facebook.com/intern/diff/D76483755/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76483755 |
## Changes * Introduce `permute_buffer.glsl` and `permute_texture.glsl` compute shader templates to implement the permute operator ## Motivation The existing implementation of permute produced incorrect outputs for width packed textures. Furthermore, there was no buffer implementation for the permute operator. My goal with this diff is to introduce a more flexible implementation of permute that could work for any tensor representation. ## Performance impact None expected. Differential Revision: [D76483755](https://our.internmc.facebook.com/intern/diff/D76483755/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76483755 |
junpi3
approved these changes
Jun 24, 2025
## Changes * Introduce `permute_buffer.glsl` and `permute_texture.glsl` compute shader templates to implement the permute operator ## Motivation The existing implementation of permute produced incorrect outputs for width packed textures. Furthermore, there was no buffer implementation for the permute operator. My goal with this diff is to introduce a more flexible implementation of permute that could work for any tensor representation. ## Performance impact None expected. Differential Revision: [D76483755](https://our.internmc.facebook.com/intern/diff/D76483755/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76483755 |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#11825 ## Changes * Introduce `permute_buffer.glsl` and `permute_texture.glsl` compute shader templates to implement the permute operator ## Motivation The existing implementation of permute produced incorrect outputs for width packed textures. Furthermore, there was no buffer implementation for the permute operator. My goal with this diff is to introduce a more flexible implementation of permute that could work for any tensor representation. ## Performance impact None expected. ghstack-source-id: 292530157 @exported-using-ghexport Differential Revision: [D76483755](https://our.internmc.facebook.com/intern/diff/D76483755/)
facebook-github-bot
merged commit 87cc2f9
into
gh/SS-JIA/245/base
96 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Changes
permute_buffer.glslandpermute_texture.glslcompute shader templates to implement the permute operatorMotivation
The existing implementation of permute produced incorrect outputs for width packed textures. Furthermore, there was no buffer implementation for the permute operator.
My goal with this diff is to introduce a more flexible implementation of permute that could work for any tensor representation.
Performance impact
None expected.
Differential Revision: D76483755