Reapply "Implement unary_ufunc functions using elementwise_util (#9386)" #11943
Conversation
This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11943
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d2a102e with merge base 75d4b2e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/) ghstack-source-id: 292469056 Pull Request resolved: #11943
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76754824 |
This PR needs a
|
…wise_util (#9386)"" This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/) [ghstack-poisoned]
Pull Request resolved: #11943 This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). ghstack-source-id: 292614913 @exported-using-ghexport Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/)
|
This pull request was exported from Phabricator. Differential Revision: D76754824 |
|
noting that this one had green tests except for lintrunner prior to last update |
…sing elementwise_util (#9386)"" This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/) [ghstack-poisoned]
Pull Request resolved: #11943 This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). ghstack-source-id: 293529492 @exported-using-ghexport Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/)
|
This pull request was exported from Phabricator. Differential Revision: D76754824 |
…_util (#9386)"" This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/) [ghstack-poisoned]
Pull Request resolved: #11943 This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure). Original summary: One less set of independent implementations to worry about going forward (e.g., we don't have to vectorize these separately from elementwise_util and they get all benefits of elementwise_util). ghstack-source-id: 293531083 @exported-using-ghexport Differential Revision: [D76754824](https://our.internmc.facebook.com/intern/diff/D76754824/)
|
This pull request was exported from Phabricator. Differential Revision: D76754824 |
|
Per discussion wiht @manuelcandales, this does not seem like we need to focus on it before GA, so I'll just convert it to draft and we'll unshelve if/when needed or post-GA. |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Hi @swolchok! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Stack from ghstack (oldest at bottom):
This PR was reverted due to internal test failures, which should be fixed now (and is being sent as an exported diff to make sure).
Original summary:
One less set of independent implementations to worry about going forward
(e.g., we don't have to vectorize these separately from elementwise_util
and they get all benefits of elementwise_util).
Differential Revision: D76754824