Reapply changes reverted by #11506 #12121
Merged
+54
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change seems to have accidentally reverted several of my changes due to (presumably) a bad rebase. Differential Revision: [D77559984](https://our.internmc.facebook.com/intern/diff/D77559984/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12121
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit 6f14cdf with merge base bed504e ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77559984 |
mcr229
approved these changes
Jun 30, 2025
This change seems to have accidentally reverted several of my changes due to (presumably) a bad rebase. Differential Revision: [D77559984](https://our.internmc.facebook.com/intern/diff/D77559984/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jul 2, 2025
Pull Request resolved: #12121 This change seems to have accidentally reverted several of my changes due to (presumably) a bad rebase. ghstack-source-id: 293898720 @exported-using-ghexport Differential Revision: [D77559984](https://our.internmc.facebook.com/intern/diff/D77559984/)
|
This pull request was exported from Phabricator. Differential Revision: D77559984 |
facebook-github-bot
merged commit 78b54ca
into
gh/swolchok/487/base
95 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
swolchok
added a commit
that referenced
this pull request
Jul 2, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #12121 by @swolchok ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/487/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/487/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/487/orig @diff-train-skip-merge Co-authored-by: Scott Wolchok <[email protected]>
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#12121 by @swolchok ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/487/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/487/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/487/orig @diff-train-skip-merge Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This change seems to have accidentally reverted several of my changes due to (presumably) a bad rebase.
Differential Revision: D77559984