Skip to content

Respect selective build for dtype_specialized_elementwise_fn_impl in elementwise_util #11975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

Respect selective build for dtype_specialized_elementwise_fn_impl in elementwise_util #11975

merged 2 commits into from
Jun 26, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jun 25, 2025

This fancy fast path I added didn't respect selective build. Now it should.

@swolchok
Update
65ff10b 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jun 25, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@swolchok swolchok requested a review from manuelcandales as a code owner June 25, 2025 17:31
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11975

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e7fce3d with merge base 3d437c3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jun 25, 2025
@swolchok
Respect selective build for dtype_specialized_elementwise_fn_impl in …
b2c78c7 
…elementwise_util

This fancy fast path I added didn't respect selective build. Now it should.


ghstack-source-id: 69988ef
ghstack-comment-id: 3005605915
Pull-Request-resolved: #11975
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2025
@github-actions
Copy link

github-actions bot commented Jun 25, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 25, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@swolchok
fix buck dep
e7fce3d 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jun 25, 2025
@swolchok
Respect selective build for dtype_specialized_elementwise_fn_impl in …
79e2259 
…elementwise_util

This fancy fast path I added didn't respect selective build. Now it should.

ghstack-source-id: e5659a3
ghstack-comment-id: 3005605915
Pull-Request-resolved: #11975
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 25, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@swolchok swolchok merged commit 8bc99d3 into main Jun 26, 2025
97 checks passed
@swolchok swolchok deleted the gh/swolchok/476/head branch June 26, 2025 00:13
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
@swolchok @hinriksnaer
Respect selective build for dtype_specialized_elementwise_fn_impl in …
059752e 
…elementwise_util (pytorch#11975)

This fancy fast path I added didn't respect selective build. Now it
should.
@swolchok swolchok mentioned this pull request Jul 2, 2025
Merged
swolchok added a commit that referenced this pull request Jul 2, 2025
@swolchok
Fix dtype selective build check in elementwise_util
6913992 
I think I got this wrong in #11975 -- the compute_dtype is the one type that is NOT related to selective build.


ghstack-source-id: db55c4a
ghstack-comment-id: 3029669540
Pull-Request-resolved: #12183
swolchok
swolchok commented Jul 2, 2025
View reviewed changes
kernels/portable/cpu/util/elementwise_util.h
CTYPE_OUT,
support_noncontiguous_tensors>(compute_fun, ctx, out, inputs...);
return;
if constexpr (should_include_kernel_dtype(op_name, compute_type)) {
Copy link
Contributor Author

@swolchok swolchok Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got this wrong. Talked to @lucylq and she confirmed that dtype selective build is about input and output tensor types, not the compute type. My plan is to fix this on main (see PR #12183 ) and to just revert this PR from the release branch for safety.

swolchok added a commit that referenced this pull request Jul 2, 2025
@swolchok
(release branch only) Revert "Respect selective build for dtype_speci…
7ac1e7a 
…alized_elementwise_fn_impl in elementwise_util (#11975)"

This reverts commit 8bc99d3. See comment on the original PR; I believe it has a bug and IIUC the correct action for the release branch is to revert to safety.
@swolchok swolchok mentioned this pull request Jul 2, 2025
Closed
larryliu0820 pushed a commit that referenced this pull request Jul 8, 2025
@swolchok
(release branch only) Revert "Respect selective build for dtype_speci…
6b7caa4 
…alized_elementwise_fn_impl in elementwise_util (#11975)" (#12184)

This reverts commit 8bc99d3. See
comment on the original PR; I believe it has a bug and IIUC the correct
action for the release branch is to revert to safety.
swolchok added a commit that referenced this pull request Jul 8, 2025
@swolchok
Fix dtype selective build check in elementwise_util (#12183)
a7db36b 
I think I got this wrong in #11975 -- the compute_dtype is the one type
that is NOT related to selective build.
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
@swolchok @Tanish2101
Fix dtype selective build check in elementwise_util (pytorch#12183)
9da61e8 
I think I got this wrong in pytorch#11975 -- the compute_dtype is the one type
that is NOT related to selective build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @facebook-github-bot @manuelcandales