-
Notifications
You must be signed in to change notification settings - Fork 741
Fix dtype selective build check in elementwise_util #12183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12183
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated FailureAs of commit 71d32cc with merge base 02454eb ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
| constexpr ScalarType out_specialized_scalar_type = | ||
| specialized_output_scalar_type<CTYPE_COMPUTE>(out_dtypes); | ||
| if constexpr (should_include_kernel_dtype( | ||
| op_name, out_specialized_scalar_type)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of should_include_kernel_dtype is behind a macro, should we not continue with that convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ET_INTERNAL_CHECK_SELECTIVE_BUILD depends implicitly on et_switch_name being defined, which doesn't make sense here, and should_include_kernel_dtype is a perfectly good constexpr function so I don't see why we shouldn't call it
|
unittest-editable failure looks like a known flake. merging. |
I think I got this wrong in pytorch#11975 -- the compute_dtype is the one type that is NOT related to selective build.
I think I got this wrong in #11975 -- the compute_dtype is the one type that is NOT related to selective build.