Skip to content

Remove unused compute_fun argument to validate_elementwise_fn_inputs #12217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2025
Merged

Remove unused compute_fun argument to validate_elementwise_fn_inputs #12217

merged 2 commits into from
Jul 8, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jul 3, 2025 •
edited
Loading

No description provided.

swolchok added 2 commits July 2, 2025 16:36
@swolchok
Update
71d32cc 
[ghstack-poisoned]
@swolchok
Update
dc41461 
[ghstack-poisoned]
@swolchok swolchok requested a review from manuelcandales as a code owner July 3, 2025 22:00
@swolchok
Copy link
Contributor Author

swolchok commented Jul 3, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12217

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit dc41461 with merge base 02454eb (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 3, 2025
@swolchok
Remove unused compute_fun argument to validate_elementwise_fn_inputs
b3446d6 
ghstack-source-id: e5b14be
ghstack-comment-id: 3033791660
Pull-Request-resolved: #12217
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2025
This was referenced Jul 3, 2025
Merged
Closed
Base automatically changed from gh/swolchok/494/head to main July 8, 2025 16:36
@swolchok swolchok added the release notes: none Do not include this in the release notes label Jul 8, 2025
@swolchok swolchok merged commit c09a00d into main Jul 8, 2025
94 of 96 checks passed
@swolchok swolchok deleted the gh/swolchok/495/head branch July 8, 2025 16:39
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
@swolchok @Tanish2101
Remove unused compute_fun argument to validate_elementwise_fn_inputs (p…
c7023be 
…ytorch#12217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @manuelcandales @facebook-github-bot