Skip to content

Conversation

swolchok
Copy link
Contributor

The CI workflow already runs strip before checking size, so this shouldn't break it (and we'll see if it does on this PR). Having debug info makes it much easier to investigate issues with bloaty.

swolchok added 3 commits June 26, 2025 13:00
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12019

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit 8782fb2 with merge base 8bc99d3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jun 26, 2025
The CI workflow already runs strip before checking size, so this shouldn't break it (and we'll see if it does on this PR). Having debug info makes it much easier to investigate issues with bloaty.


ghstack-source-id: d15388a
ghstack-comment-id: 3009793476
Pull-Request-resolved: #12019
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2025
@swolchok
Copy link
Contributor Author

swolchok commented Jun 26, 2025

looks like we need to run strip -s

[ghstack-poisoned]
swolchok added 2 commits June 26, 2025 17:28
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok changed the base branch from gh/swolchok/478/head to gh/swolchok/482/head June 27, 2025 00:28
swolchok added a commit that referenced this pull request Jun 27, 2025
swolchok added a commit that referenced this pull request Jun 27, 2025
Base automatically changed from gh/swolchok/482/head to main June 28, 2025 00:02
@swolchok swolchok requested a review from manuelcandales as a code owner June 28, 2025 00:02
@swolchok
Copy link
Contributor Author

this one looks like a can of worms and the benefit for the cost isn't there. abandoning.

@swolchok swolchok closed this Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants