outline input validation in elementwise_util

[swolchok]

This seems to improve code size. Comparing output of test/build_optimized_size_test.sh before/after this change:

(I've edited out the unchanged "no ops" test case.)

before:

ExecuTorch with portable ops binary size, unstripped:
-rwxr-xr-x  1 swolchok  staff  2004816 Jun 26 14:02 cmake-out/test/size_test_all_ops
__TEXT	__DATA	__OBJC	others	dec	hex
1441792	65536	0	4295524352	4297031680	1001f8000
ExecuTorch with optimized ops binary size, unstripped:
-rwxr-xr-x  1 swolchok  staff  6746968 Jun 26 14:02 cmake-out/test/size_test_all_optimized_ops
__TEXT	__DATA	__OBJC	others	dec	hex
4947968	65536	0	4296753152	4301766656	10067c000

after:

ExecuTorch with portable ops binary size, unstripped:
-rwxr-xr-x  1 swolchok  staff  1989392 Jun 26 14:37 cmake-out/test/size_test_all_ops
__TEXT	__DATA	__OBJC	others	dec	hex
1425408	65536	0	4295524352	4297015296	1001f4000
ExecuTorch with optimized ops binary size, unstripped:
-rwxr-xr-x  1 swolchok  staff  6731784 Jun 26 14:37 cmake-out/test/size_test_all_optimized_ops
__TEXT	__DATA	__OBJC	others	dec	hex
4931584	65536	0	4296753152	4301750272	100678000

for test/build_size_test.sh, we see a smaller improvment which is reflected in the file sizes but not the size command output, probably because the latter is rounded up to the next page:

before:

ExecuTorch with portable ops binary size, unstripped:
-rwxr-xr-x  1 swolchok  staff  2696640 Jun 26 13:44 cmake-out/test/size_test_all_ops
__TEXT	__DATA	__OBJC	others	dec	hex
2162688	65536	0	4295491584	4297719808	1002a0000

after:

ExecuTorch with portable ops binary size, unstripped:
-rwxr-xr-x  1 swolchok  staff  2695344 Jun 26 14:33 cmake-out/test/size_test_all_ops
__TEXT	__DATA	__OBJC	others	dec	hex
2162688	65536	0	4295491584	4297719808	1002a0000

[swolchok]

Stack from ghstack (oldest at bottom):

• -> outline input validation in elementwise_util #12031
• Specialize BroadcastIndexesRange for the case where there is only 1 contiguous input #12023
• Build size_test binaries with debug info #12019
• Detect release builds by comparing CMAKE_BUILD_TYPE to Debug, not Release #12045
• Show output of the size command in size test scripts #12018
• Unbreak build_size_test.sh (-Wvla-cxx-extension) on my local machine #12017

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12031

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• VolumeLimitExceeded Issue for linux.2xlarge and linux.4xlarge

❌ 3 New Failures, 1 Unrelated Failure

As of commit 9f740d9 with merge base 8bc99d3 ():

NEW FAILURES - The following jobs have failed:

• Lint / lintrunner / linux-job (gh)
  >>> Lint for kernels/portable/cpu/util/elementwise_util.cpp:
• pull / test-binary-size-linux / linux-job (gh)
  RuntimeError: Command docker exec -t f9f2f53525bb3e10a8f2365e66c46ef083a2718fcc98029f3063495df77a3c02 /exec failed with exit code 1
• pull / test-binary-size-linux-gcc / linux-job (gh)
  RuntimeError: Command docker exec -t f43e91a6bc5b714e020aa44e9bddd1d8b49dfb5f6fad0c2e5e0d9a4fcf9b7d66 /exec failed with exit code 1

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• pull / android / run-emulator (gh) (trunk failure)
  The process '/usr/bin/sh' failed with exit code 255

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[swolchok]

this now looks like a regression to me