Skip to content

Parallelize optimized op_log_softmax #12099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Parallelize optimized op_log_softmax #12099

merged 2 commits into from
Jul 3, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jun 30, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Straightforward application of parallel_for.

Differential Revision: D76831122

@swolchok
Parallelize optimized op_log_softmax
a04da54 
Straightforward application of parallel_for.

Differential Revision: [D76831122](https://our.internmc.facebook.com/intern/diff/D76831122/)

[ghstack-poisoned]
@swolchok swolchok requested a review from manuelcandales as a code owner June 30, 2025 00:17
@swolchok swolchok mentioned this pull request Jun 30, 2025
Merged
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12099

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs

As of commit bd32947 with merge base bed504e (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jun 30, 2025
@swolchok
Parallelize optimized op_log_softmax
dc4bf90 
Straightforward application of parallel_for.

Differential Revision: [D76831122](https://our.internmc.facebook.com/intern/diff/D76831122/)

ghstack-source-id: 293375210
Pull Request resolved: #12099
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 30, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76831122

@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jun 30, 2025
@swolchok
Copy link
Contributor Author

pull / android / run-emulator is consistently telling us this is broken, but the bug is not obvious to me on rereading

@swolchok
Copy link
Contributor Author

after rereading the code twice, I was inclined to suspect that the kernel is somehow thread-unsafe, so I built with TSAN locally (-fsanitize=debug, CMAKE_BUILD_TYPE=RelWithDebInfo so parallel_for will actually parallelize) and didn't catch a failure. doesn't look like a pre-existing issue on HUD or anything so we shouldn't bypass, but I'm not sure what to do next. Nobody is particularly asking for parallelization AFAIK so there's no rush...

@swolchok
Update on "Parallelize optimized op_log_softmax"
bd32947 
Straightforward application of parallel_for.

Differential Revision: [D76831122](https://our.internmc.facebook.com/intern/diff/D76831122/)

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 2, 2025
@swolchok
Parallelize optimized op_log_softmax
5caf5c9 
Pull Request resolved: #12099

Straightforward application of parallel_for.
ghstack-source-id: 293901059
@exported-using-ghexport

Differential Revision: [D76831122](https://our.internmc.facebook.com/intern/diff/D76831122/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76831122

@swolchok
Copy link
Contributor Author

swolchok commented Jul 2, 2025

android / run-emulator is no longer complaining. I guess that means this is landable!

@swolchok swolchok requested a review from SS-JIA July 2, 2025 22:46
@swolchok
Copy link
Contributor Author

swolchok commented Jul 3, 2025

mobilebert has been timing out on HUD, bypassing

@facebook-github-bot facebook-github-bot merged commit f4f220d into gh/swolchok/486/base Jul 3, 2025
165 of 171 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/486/head branch July 3, 2025 23:25
@metascroy metascroy restored the gh/swolchok/486/head branch July 4, 2025 17:45
@swolchok swolchok mentioned this pull request Jul 7, 2025
Merged
swolchok added a commit that referenced this pull request Jul 7, 2025
@swolchok
Manual cherry-pick: Parallelize optimized op_log_softmax
8bfed01 
This landed internally and PR #12099 closed, but the bot couldn't pick it. Here's a manual pick.

Differential Revision: D76831122


ghstack-source-id: 721fa97
ghstack-comment-id: 3045906835
Pull-Request-resolved: #12246
swolchok added a commit that referenced this pull request Jul 7, 2025
@swolchok
Manual cherry-pick: Parallelize optimized op_log_softmax (#12246)
c778063 
This landed internally and PR
#12099 closed, but the bot
couldn't pick it. Here's a manual pick.

Differential Revision: D76831122
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
@swolchok @Tanish2101
Manual cherry-pick: Parallelize optimized op_log_softmax (pytorch#12246)
c2f03c4 
This landed internally and PR
pytorch#12099 closed, but the bot
couldn't pick it. Here's a manual pick.

Differential Revision: D76831122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @facebook-github-bot @SS-JIA