Arm backend: Split executor runner into init + run #12162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the main function of arm_executor_runner.cpp by extracting code that is related to initializing and running a model into two separate helper functions (runner_init and RunnerContext::run). A new struct called RunnerContext is introduced to store data/context required to run the model. Change-Id: Iaca06d6f12b84644ce76e23e8881787a7971cdaa
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12162
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 5 Cancelled Jobs, 1 Unrelated FailureAs of commit 9c58427 with merge base bed504e ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label ciflow/trunk |
|
@pytorchbot label "partner: arm" |
pytorch-bot
bot
added
the
partner: arm
|
Fails are unrelated and fail on main also |
zingo
approved these changes
Jul 2, 2025
metascroy
added a commit
that referenced
this pull request
Jul 2, 2025
Reverts #12162 This fails internal CI. @digantdesai can you have a look
BujSet
pushed a commit
to BujSet/executorch
that referenced
this pull request
Jul 2, 2025
Refactor the main function of arm_executor_runner.cpp by extracting code that is related to initializing and running a model into two separate helper functions (runner_init and RunnerContext::run). A new struct called RunnerContext is introduced to store data/context required to run the model. ### Test plan The code is tested in the CI. It's a refactoring patch, so no new functionality added/removed. Co-authored-by: Martin Lindström <[email protected]>
|
What errors/problems did you see @metascroy ? |
swolchok
reviewed
Jul 3, 2025
|
|
||
| namespace { | ||
|
|
||
| /// Lightweight heapless container that constructs and stores a T in-place. |
There was a problem hiding this comment.
why not use std::optional? this appears roughly equivalent, but I read it quickly and might've missed something
zingo
pushed a commit
that referenced
this pull request
Jul 7, 2025
…12197) The PR #12162 got reverted with #12171. This PR is a resubmission of the patch. Refactor the main function of arm_executor_runner.cpp by extracting code that is related to initializing and running a model into two separate helper functions (runner_init and RunnerContext::run). A new struct called RunnerContext is introduced to store data/context required to run the model. ### Test plan Arm's CI runs and tests the changed code. Co-authored-by: Martin Lindström <[email protected]>
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
Refactor the main function of arm_executor_runner.cpp by extracting code that is related to initializing and running a model into two separate helper functions (runner_init and RunnerContext::run). A new struct called RunnerContext is introduced to store data/context required to run the model. ### Test plan The code is tested in the CI. It's a refactoring patch, so no new functionality added/removed. Co-authored-by: Martin Lindström <[email protected]>
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
…12171) Reverts pytorch#12162 This fails internal CI. @digantdesai can you have a look
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
…ytorch#12197) The PR pytorch#12162 got reverted with pytorch#12171. This PR is a resubmission of the patch. Refactor the main function of arm_executor_runner.cpp by extracting code that is related to initializing and running a model into two separate helper functions (runner_init and RunnerContext::run). A new struct called RunnerContext is introduced to store data/context required to run the model. ### Test plan Arm's CI runs and tests the changed code. Co-authored-by: Martin Lindström <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the main function of arm_executor_runner.cpp by extracting code that is related to initializing and running a model into two separate helper functions (runner_init and RunnerContext::run). A new struct called RunnerContext is introduced to store data/context required to run the model.
Test plan
The code is tested in the CI. It's a refactoring patch, so no new functionality added/removed.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218