Skip to content

Conversation

@wwwind
Copy link
Collaborator

@wwwind wwwind commented Jul 11, 2025

Summary:
Add function to return quant params for lowered graph and remove these Q/DQ from the graph. If they are needed, then the EdgeProgramManager should be copied before use of this function.

Change-Id: I09de39c603d68d5ac5de4614a35eb7e3fc9ba518

Signed-off-by: Elena Zhelezina [email protected]

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Signed-off-by: Elena Zhelezina <[email protected]>
Change-Id: I09de39c603d68d5ac5de4614a35eb7e3fc9ba518
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12390

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 16 Pending, 5 Unrelated Failures

As of commit 62db20b with merge base aaf0a4c (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2025
@wwwind wwwind added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Jul 11, 2025
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I am missing something, can you help me understand the motivation please?

from executorch.exir.passes.quantize_io_pass import QuantizeInputs, QuantizeOutputs


def extract_io_quant_params(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move this to the quantize_io_pass.py?

@wwwind
Copy link
Collaborator Author

wwwind commented Jul 11, 2025

Thank you for the review! @digantdesai

We need this function in our workflow: we have a graphic use case when we need to move out Q/DQ nodes and get scale/zero points so we prepare input data in our plugin. Then we pass it to the subgraph. Currently, we need to call these two passes and then to extract these data from config, which is not very friendly for our users. Here there is just one function call that does this job.

@digantdesai
Copy link
Contributor

Sound good. Can you please move this util in the pass file? Thanks.

@wwwind
Copy link
Collaborator Author

wwwind commented Jul 15, 2025

Replaced with #12481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants