Skip to content

Conversation

@wwwind
Copy link
Collaborator

@wwwind wwwind commented Jul 15, 2025

Summary:
Add function to return quant params for lowered graph and remove these Q/DQ from the graph. If they are needed, then the EdgeProgramManager should be copied before use of this function.

This is a replacement of PR #12390

Change-Id: I74d7292252c6daf1486ef28bbb2dcffdd34cd7b7
Signed-off-by: Elena Zhelezina [email protected]

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Signed-off-by: Elena Zhelezina <[email protected]>
Change-Id: I74d7292252c6daf1486ef28bbb2dcffdd34cd7b7
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12481

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 9d03eba with merge base 3ab7063 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2025
@wwwind wwwind added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Jul 15, 2025
@Sebastian-Larsson
Copy link
Collaborator

@digantdesai Please take a look at this PR since it touches files outside of the arm backend

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming not much changed since #12390

Besides the code move to the pass file?

@wwwind
Copy link
Collaborator Author

wwwind commented Jul 24, 2025

@digantdesai yes, nothing changed - this is the only change

@Sebastian-Larsson Sebastian-Larsson merged commit 92fb0cc into pytorch:main Jul 24, 2025
198 of 199 checks passed
Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025
Summary:
Add function to return quant params for lowered graph and remove these
Q/DQ from the graph. If they are needed, then the EdgeProgramManager
should be copied before use of this function.

Signed-off-by: Elena Zhelezina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants