-
Notifications
You must be signed in to change notification settings - Fork 743
add slice op in _is_share_obs_or_fq_op function to fix staticslice op in quantization #12416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add slice op in _is_share_obs_or_fq_op function to fix staticslice op in quantization #12416
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12416
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 1 Cancelled JobAs of commit 47a8de6 with merge base c2d6f3d ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @barbecacov! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
This PR needs a
|
| torch.ops.aten.slice_copy.Tensor, | ||
| torch.ops.aten.flatten.using_ints, | ||
| torch.ops.aten.slice.Tensor, | ||
| torch.ops.aten.select.int, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you need all of these? I think slice.Tensor should be sufficient right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, i am not sure. May just torch.ops.aten.slice.Tensor
|
@barbecacov I think you need to sign the CLA before we can merge this. Thanks for the fix BTW. |
|
@digantdesai Thank you. I just signed. |
|
failures don't seem relevant. I'll stamp |
|
@digantdesai Hello, is it ok to merge to master branch? |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary
Caz xnnpack require the zero point of staticslice are same in inputs/outputs, so add slice op in _is_share_obs_or_fq_op to share quantization parameters