Skip to content

add slice op in _is_share_obs_or_fq_op function to fix staticslice op in quantization #12416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add slice op in _is_share_obs_or_fq_op function to fix staticslice op in quantization #12416

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71af9b9
add slice op in _is_share_obs_or_fq_op function
barbecacov Jul 11, 2025
82080f4
Update xnnpack_quantizer_utils.py
barbecacov Jul 11, 2025
47a8de6
Merge branch 'main' into fix-staticslice_quantization-bug
barbecacov Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backends/xnnpack/quantizer/xnnpack_quantizer_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1060,6 +1060,9 @@ def _is_share_obs_or_fq_op(op: Callable) -> bool:
torch.ops.aten.view.default,
torch.ops.aten.slice_copy.Tensor,
torch.ops.aten.flatten.using_ints,
torch.ops.aten.slice.Tensor,
torch.ops.aten.select.int,
Copy link
Contributor

@mcr229 mcr229 Jul 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you need all of these? I think slice.Tensor should be sufficient right?

Copy link
Author

@barbecacov barbecacov Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i am not sure. May just torch.ops.aten.slice.Tensor

torch.ops.aten.index_select.default,
]


Expand Down