Skip to content

Check overflow in allocation #12683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Jul 23, 2025
Merged

Check overflow in allocation #12683

facebook-github-bot merged 1 commit into from
Jul 23, 2025

Conversation

@JacobSzwejbka
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka commented Jul 21, 2025

Summary: Overflow is unsafe as a user will get back much less memory then expected

Differential Revision: D78678540

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12683

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9ba1c99 with merge base b183830 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 21, 2025

This pull request was exported from Phabricator. Differential Revision: D78678540

@github-actions
Copy link

github-actions bot commented Jul 21, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 22, 2025
@JacobSzwejbka @facebook-github-bot
Check overflow in allocation (pytorch#12683)
a4fb7f1 
Summary:

Overflow is unsafe as a user will get back much less memory then expected

Differential Revision: D78678540
lucylq
lucylq approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter?

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 22, 2025
@JacobSzwejbka @facebook-github-bot
Check overflow in allocation (pytorch#12683)
2eb0e87 
Summary:

Overflow is unsafe as a user will get back much less memory then expected

Reviewed By: lucylq

Differential Revision: D78678540
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 22, 2025

This pull request was exported from Phabricator. Differential Revision: D78678540

@JacobSzwejbka @facebook-github-bot
Check overflow in allocation (pytorch#12683)
9ba1c99 
Summary:

Overflow is unsafe as a user will get back much less memory then expected

Reviewed By: lucylq

Differential Revision: D78678540
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 23, 2025

This pull request was exported from Phabricator. Differential Revision: D78678540

@facebook-github-bot facebook-github-bot merged commit 8f062d3 into pytorch:main Jul 23, 2025
100 of 101 checks passed
Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025
@JacobSzwejbka @Conarnar
Check overflow in allocation
3e3a846 
Differential Revision: D78678540

Pull Request resolved: pytorch#12683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucylq lucylq lucylq approved these changes

@swolchok swolchok Awaiting requested review from swolchok

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JacobSzwejbka @facebook-github-bot @lucylq