Skip to content

Check overflow in allocation #12683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
facebook-github-bot merged 1 commit into from
Jul 23, 2025
Merged

Check overflow in allocation #12683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion runtime/core/memory_allocator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#include <cinttypes>
#include <cstdint>

#include <c10/util/safe_numerics.h>

#include <executorch/runtime/core/error.h>
#include <executorch/runtime/platform/assert.h>
#include <executorch/runtime/platform/compiler.h>
Expand Down Expand Up @@ -137,7 +139,16 @@ class MemoryAllocator {
// Some users of this method allocate lists of pointers, causing the next
// line to expand to `sizeof(type *)`, which triggers a clang-tidy warning.
// NOLINTNEXTLINE(bugprone-sizeof-expression)
return static_cast<T*>(this->allocate(size * sizeof(T), alignment));
size_t bytes_size = 0;
bool overflow = c10::mul_overflows(size, sizeof(T), &bytes_size);
if (overflow) {
ET_LOG(
Error,
"Failed to allocate list of type %zu: size * sizeof(T) overflowed",
size);
return nullptr;
}
return static_cast<T*>(this->allocate(bytes_size, alignment));
}

// Returns the allocator memory's base address.
Expand Down
Loading