Move to Span<EValue*> instead of EValue** in delegate interface #13004

JacobSzwejbka · 2025-07-30T17:14:51Z

Summary: For better safety we want to provide a pointer and a length instead of just a pointer. This is a breaking change of the delegate interface so have to update everyone at once. Span implements operator [], so I expect this to functionally be a no-op today.

Differential Revision: D79268134

pytorch-bot · 2025-07-30T17:14:54Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13004

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 16acb4b with merge base 650b32f ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
At least one of the pre-conditions you specified did not hold
pull / unittest / macos / macos-job (gh)
backends/xnnpack/test/ops/test_conv1d.py::TestConv1d::test_qs8_conv1d_batchnorm_seq

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / test-quantized-aot-lib-linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-07-30T17:15:01Z

This pull request was exported from Phabricator. Differential Revision: D79268134

JacobSzwejbka · 2025-07-30T17:15:51Z

All Ive done so far is just a find and replace code mod. Im sure I have to go through and fix 1 billion individual issues. Just wanted to get this out early to give backend authors a heads up on the change.

mcr229 · 2025-07-30T17:26:42Z

backends/xnnpack/runtime/XNNExecutor.h

   */
  ET_NODISCARD executorch::runtime::Error prepare_args(
-      executorch::runtime::EValue** args);
+      executorch::runtime::Span<EValue*> args);


think you need to add the executorch::runtime::Evalue namespace for evalue still.

facebook-github-bot · 2025-08-06T20:11:36Z

This pull request was exported from Phabricator. Differential Revision: D79268134

…rch#13004) Summary: Pull Request resolved: pytorch#13004 For better safety we want to provide a pointer and a length instead of just a pointer. This is a breaking change of the delegate interface so have to update everyone at once. Span implements operator [], so I expect this to functionally be a no-op today. Differential Revision: D79268134

facebook-github-bot · 2025-08-06T21:04:22Z

This pull request was exported from Phabricator. Differential Revision: D79268134

…rch#13004) Summary: Pull Request resolved: pytorch#13004 For better safety we want to provide a pointer and a length instead of just a pointer. This is a breaking change of the delegate interface so have to update everyone at once. Span implements operator [], so I expect this to functionally be a no-op today. Differential Revision: D79268134

facebook-github-bot · 2025-08-06T21:25:41Z

This pull request was exported from Phabricator. Differential Revision: D79268134

…rch#13004) Summary: Pull Request resolved: pytorch#13004 For better safety we want to provide a pointer and a length instead of just a pointer. This is a breaking change of the delegate interface so have to update everyone at once. Span implements operator [], so I expect this to functionally be a no-op today. Differential Revision: D79268134

…rch#13004) Summary: For better safety we want to provide a pointer and a length instead of just a pointer. This is a breaking change of the delegate interface so have to update everyone at once. Span implements operator [], so I expect this to functionally be a no-op today. Differential Revision: D79268134

facebook-github-bot · 2025-08-08T17:28:29Z

This pull request was exported from Phabricator. Differential Revision: D79268134

…rch#13004) Summary: For better safety we want to provide a pointer and a length instead of just a pointer. This is a breaking change of the delegate interface so have to update everyone at once. Span implements operator [], so I expect this to functionally be a no-op today. Differential Revision: D79268134

facebook-github-bot · 2025-08-08T17:44:04Z

This pull request was exported from Phabricator. Differential Revision: D79268134

cccclai

Makes sense

…rch#13004) Summary: For better safety we want to provide a pointer and a length instead of just a pointer. This is a breaking change of the delegate interface so have to update everyone at once. Span implements operator [], so I expect this to functionally be a no-op today. Differential Revision: D79268134

facebook-github-bot · 2025-08-11T17:34:15Z

This pull request was exported from Phabricator. Differential Revision: D79268134

…rch#13004) Summary: Pull Request resolved: pytorch#13004 For better safety we want to provide a pointer and a length instead of just a pointer. This is a breaking change of the delegate interface so have to update everyone at once. Span implements operator [], so I expect this to functionally be a no-op today. Differential Revision: D79268134

facebook-github-bot · 2025-08-11T17:37:51Z

This pull request was exported from Phabricator. Differential Revision: D79268134

The PR pytorch#13004 moved `EValue` to the `Span` namespace but did not add the corresponding using-declaration in VGFBackend.cpp. Adds the missing using-declaration to fix the build. Change-Id: I58f1acff3fec41aee433283495ff4bbf6cb34512 Signed-off-by: Yufeng Shi <[email protected]>

The PR #13004 moved `EValue` to the `Span` namespace but did not add the corresponding using-declaration in VGFBackend.cpp. Adds the missing using-declaration to fix the build. Signed-off-by: Yufeng Shi <[email protected]>

Differential Revision: D79268134 Pull Request resolved: pytorch#13004

…#13460) The PR pytorch#13004 moved `EValue` to the `Span` namespace but did not add the corresponding using-declaration in VGFBackend.cpp. Adds the missing using-declaration to fix the build. Signed-off-by: Yufeng Shi <[email protected]>

JacobSzwejbka requested review from SS-JIA, cccclai, digantdesai, larryliu0820, lucylq, mcr229, mergennachin, shoumikhin and swolchok as code owners July 30, 2025 17:14

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2025

facebook-github-bot added the fb-exported label Jul 30, 2025

mcr229 reviewed Jul 30, 2025

View reviewed changes

JacobSzwejbka force-pushed the export-D79268134 branch from 8a705d8 to 7f9e565 Compare August 6, 2025 20:11

JacobSzwejbka force-pushed the export-D79268134 branch from 7f9e565 to c3c6e24 Compare August 6, 2025 21:04

JacobSzwejbka force-pushed the export-D79268134 branch 2 times, most recently from 703fdc9 to d7d027d Compare August 8, 2025 17:28

JacobSzwejbka force-pushed the export-D79268134 branch from d7d027d to 33a9639 Compare August 8, 2025 17:43

cccclai added the release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) label Aug 11, 2025

cccclai approved these changes Aug 11, 2025

View reviewed changes

cccclai requested review from DannyYuyang-quic, YifanShenSZ, haowhsu-quic, neuropilot-captain, shewu-quic and winskuo-quic August 11, 2025 17:09

JacobSzwejbka force-pushed the export-D79268134 branch from 33a9639 to 76cec45 Compare August 11, 2025 17:34

JacobSzwejbka force-pushed the export-D79268134 branch from 76cec45 to a9e0867 Compare August 11, 2025 17:34

JacobSzwejbka force-pushed the export-D79268134 branch from a9e0867 to 16acb4b Compare August 11, 2025 17:37

facebook-github-bot merged commit 8e73c09 into pytorch:main Aug 12, 2025
179 of 188 checks passed

YufengShi-dudu mentioned this pull request Aug 15, 2025

Arm backend: Add missing using-declaration in VGFBackend.cpp #13460

Merged

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025

Move to Span<EValue*> instead of EValue** in delegate interface

da3a5e5

Differential Revision: D79268134 Pull Request resolved: pytorch#13004

Move to Span<EValue*> instead of EValue** in delegate interface #13004

Move to Span<EValue*> instead of EValue** in delegate interface #13004

Uh oh!

Conversation

JacobSzwejbka commented Jul 30, 2025

Uh oh!

pytorch-bot bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13004

❌ 2 New Failures, 1 Unrelated Failure

Uh oh!

facebook-github-bot commented Jul 30, 2025

Uh oh!

JacobSzwejbka commented Jul 30, 2025

Uh oh!

mcr229 Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Aug 6, 2025

Uh oh!

facebook-github-bot commented Aug 6, 2025

Uh oh!

facebook-github-bot commented Aug 6, 2025

Uh oh!

facebook-github-bot commented Aug 8, 2025

Uh oh!

facebook-github-bot commented Aug 8, 2025

Uh oh!

cccclai left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Aug 11, 2025

Uh oh!

facebook-github-bot commented Aug 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pytorch-bot bot commented Jul 30, 2025 •

edited

Loading