Skip to content

Correct the flatc/flatcc compilation for x86 ios simulator #13080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Correct the flatc/flatcc compilation for x86 ios simulator #13080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
521f703
Correct the flatc/flatcc compilation for x86 ios simulator
ykhrustalev Aug 2, 2025
e6d20ef
Merge branch 'main' into ykhrustalev/ios-sim
ykhrustalev Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions third-party/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ ExternalProject_Add(
# Unset the toolchain to build for the host instead of the toolchain set for the project.
-DCMAKE_TOOLCHAIN_FILE=
# If building for iOS, "unset" these variables to rely on the host (macOS) defaults.
$<$<AND:$<BOOL:${APPLE}>,$<BOOL:$<FILTER:${PLATFORM},EXCLUDE,^MAC>>>:-DCMAKE_OSX_SYSROOT=>
$<$<STREQUAL:$<LOWER_CASE:${CMAKE_SYSTEM_NAME}>,ios>:-DCMAKE_OSX_SYSROOT=macosx>
Copy link
Contributor

@kimishpatel kimishpatel Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larryliu0820 any objections?

-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=${CMAKE_OSX_DEPLOYMENT_TARGET}
BUILD_BYPRODUCTS <INSTALL_DIR>/bin/flatc
${_executorch_external_project_additional_args}
Expand Down Expand Up @@ -91,7 +91,7 @@ ExternalProject_Add(
-DCMAKE_INSTALL_PREFIX:PATH=<INSTALL_DIR>
-DCMAKE_POSITION_INDEPENDENT_CODE=ON
-DCMAKE_TOOLCHAIN_FILE=
$<$<AND:$<BOOL:${APPLE}>,$<BOOL:$<FILTER:${PLATFORM},EXCLUDE,^MAC>>>:-DCMAKE_OSX_SYSROOT=>
$<$<STREQUAL:$<LOWER_CASE:${CMAKE_SYSTEM_NAME}>,ios>:-DCMAKE_OSX_SYSROOT=macosx>
-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=${CMAKE_OSX_DEPLOYMENT_TARGET}
${_flatcc_extra_cmake_args}
BUILD_BYPRODUCTS <INSTALL_DIR>/bin/flatcc
Expand Down
Loading