[Executorch][Recipes][Coreml] Add coreml backend recipes #13121

abhinaykukkadapu · 2025-08-05T01:06:43Z

Summary

Adds coreml recipes as discussed similar to xnnpack backend recipes to use them for export flow.

Fixes #13100

Test plan

python -m unittest backends/apple/coreml/test/test_coreml_recipes.py

pytorch-bot · 2025-08-05T01:06:46Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13121

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 78 Pending

As of commit 4c34f87 with merge base 41d05fe ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-08-05T01:07:17Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

backends/apple/coreml/recipes/coreml_recipe_types.py

facebook-github-bot · 2025-08-05T16:51:25Z

@abhinaykukkadapu has imported this pull request. If you are a Meta employee, you can view this in D79654041.

facebook-github-bot · 2025-08-05T17:51:33Z

This pull request was exported from Phabricator. Differential Revision: D79654041

Summary: Adds coreml recipes as discussed similar to xnnpack backend recipes to use them for export flow. Fixes pytorch#13100 Pull Request resolved: pytorch#13121 Test Plan: `python -m unittest backends/apple/coreml/test/test_coreml_recipes.py` Differential Revision: D79654041 Pulled By: abhinaykukkadapu

backends/apple/coreml/recipes/coreml_recipe_types.py

metascroy · 2025-08-06T00:07:22Z

backends/apple/coreml/test/test_coreml_recipes.py

+    CoreMLRecipeProvider,
+    CoreMLRecipeType,
+)
+from executorch.backends.apple.coreml.test.test_torch_ops import _TEST_RUNTIME


Nit: rather than import from the other test, factor _TEST_RUNTIME out into a common test_util and use in both tests.

backends/apple/coreml/test/test_coreml_recipes.py

metascroy · 2025-08-06T00:10:21Z

backends/apple/coreml/recipes/coreml_recipe_provider.py

+
+        return ExportRecipe(
+            name=recipe_type.value,
+            quantization_recipe=None,  # TODO - add quantization recipe


FYI: I have a PR updating CoreML docs that you might check out for quantization and available partitioner options: #13120

@metascroy it might make sense for you to follow up on the recipes for quant

Sure, @abhinaykukkadapu are the quant recipes coming in a future PR?

@metascroy If you want to follow up, i can leave it upto you as you have more context on quantization, or i can take it up if you don't have bandwidth.

You can add the quantization recipe, I'm happy to review the quantize_ and PT2E recipes you add for CoreML

@metascroy sure will add in a follow up diff, can we go ahead with these changes?

backends/apple/coreml/recipes/coreml_recipe_provider.py

Summary: Adds coreml recipes as discussed similar to xnnpack backend recipes to use them for export flow. Fixes pytorch#13100 Pull Request resolved: pytorch#13121 Test Plan: `python -m unittest backends/apple/coreml/test/test_coreml_recipes.py` Differential Revision: D79654041 Pulled By: abhinaykukkadapu

facebook-github-bot · 2025-08-08T16:30:37Z

@abhinaykukkadapu has imported this pull request. If you are a Meta employee, you can view this in D79654041.

Summary: Adds coreml recipes as discussed similar to xnnpack backend recipes to use them for export flow. Fixes pytorch#13100 Pull Request resolved: pytorch#13121 Test Plan: `python -m unittest backends/apple/coreml/test/test_coreml_recipes.py` Reviewed By: metascroy Differential Revision: D79654041 Pulled By: abhinaykukkadapu

facebook-github-bot · 2025-08-08T16:50:43Z

This pull request was exported from Phabricator. Differential Revision: D79654041

Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY INT4_WEIGHT_ONLY_PER_CHANNEL INT4_WEIGHT_ONLY_PER_GROUP INT8_WEIGHT_ONLY_PER_CHANNEL INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/) [ghstack-poisoned]

Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY INT4_WEIGHT_ONLY_PER_CHANNEL INT4_WEIGHT_ONLY_PER_GROUP INT8_WEIGHT_ONLY_PER_CHANNEL INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/) ghstack-source-id: 302827577 Pull Request resolved: #13387

Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY INT4_WEIGHT_ONLY_PER_CHANNEL INT4_WEIGHT_ONLY_PER_GROUP INT8_WEIGHT_ONLY_PER_CHANNEL INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/) [ghstack-poisoned]

Pull Request resolved: #13387 Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY INT4_WEIGHT_ONLY_PER_CHANNEL INT4_WEIGHT_ONLY_PER_GROUP INT8_WEIGHT_ONLY_PER_CHANNEL INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY ghstack-source-id: 302842396 @exported-using-ghexport Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/)

Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY INT4_WEIGHT_ONLY_PER_CHANNEL INT4_WEIGHT_ONLY_PER_GROUP INT8_WEIGHT_ONLY_PER_CHANNEL INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/) [ghstack-poisoned]

Pull Request resolved: #13387 Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY INT4_WEIGHT_ONLY_PER_CHANNEL INT4_WEIGHT_ONLY_PER_GROUP INT8_WEIGHT_ONLY_PER_CHANNEL INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY ghstack-source-id: 302857006 @exported-using-ghexport Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/)

Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY INT4_WEIGHT_ONLY_PER_CHANNEL INT4_WEIGHT_ONLY_PER_GROUP INT8_WEIGHT_ONLY_PER_CHANNEL INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/) [ghstack-poisoned]

Pull Request resolved: #13387 Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY INT4_WEIGHT_ONLY_PER_CHANNEL INT4_WEIGHT_ONLY_PER_GROUP INT8_WEIGHT_ONLY_PER_CHANNEL INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY ghstack-source-id: 302870102 @exported-using-ghexport Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/)

Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY INT4_WEIGHT_ONLY_PER_CHANNEL INT4_WEIGHT_ONLY_PER_GROUP INT8_WEIGHT_ONLY_PER_CHANNEL INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/) [ghstack-poisoned]

Pull Request resolved: #13387 Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY TORCHAO_INT4_WEIGHT_ONLY_PER_CHANNEL TORCHAO_INT4_WEIGHT_ONLY_PER_GROUP TORCHAO_INT8_WEIGHT_ONLY_PER_CHANNEL TORCHAO_INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY ghstack-source-id: 303044428 @exported-using-ghexport Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/)

Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY INT4_WEIGHT_ONLY_PER_CHANNEL INT4_WEIGHT_ONLY_PER_GROUP INT8_WEIGHT_ONLY_PER_CHANNEL INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/) [ghstack-poisoned]

Pull Request resolved: #13387 Fixing tests for stack that got reverted: #13265 Adds coreml quant recipes after FP32/16 recipes added in #13121 Recipes added: PT2E_INT8_STATIC PT2E_INT8_WEIGHT_ONLY TORCHAO_INT4_WEIGHT_ONLY_PER_CHANNEL TORCHAO_INT4_WEIGHT_ONLY_PER_GROUP TORCHAO_INT8_WEIGHT_ONLY_PER_CHANNEL TORCHAO_INT8_WEIGHT_ONLY_PER_GROUP CODEBOOK_WEIGHT_ONLY ghstack-source-id: 303126085 @exported-using-ghexport Differential Revision: [D80206542](https://our.internmc.facebook.com/intern/diff/D80206542/)

abhinaykukkadapu requested a review from metascroy August 5, 2025 01:06

abhinaykukkadapu requested review from cccclai and shoumikhin as code owners August 5, 2025 01:06

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2025

abhinaykukkadapu commented Aug 5, 2025

View reviewed changes

backends/apple/coreml/recipes/coreml_recipe_types.py Show resolved Hide resolved

abhinaykukkadapu force-pushed the coreml_backend_recipes branch from 86e07ac to 0695ac8 Compare August 5, 2025 16:26

facebook-github-bot added the fb-exported label Aug 5, 2025

abhinaykukkadapu force-pushed the coreml_backend_recipes branch from 0695ac8 to a757493 Compare August 5, 2025 17:51

abhinaykukkadapu requested a review from kimishpatel August 5, 2025 20:34

metascroy reviewed Aug 6, 2025

View reviewed changes

backends/apple/coreml/recipes/coreml_recipe_types.py Outdated Show resolved Hide resolved

metascroy reviewed Aug 6, 2025

View reviewed changes

backends/apple/coreml/test/test_coreml_recipes.py Outdated Show resolved Hide resolved

metascroy reviewed Aug 6, 2025

View reviewed changes

backends/apple/coreml/recipes/coreml_recipe_provider.py Outdated Show resolved Hide resolved

metascroy reviewed Aug 6, 2025

View reviewed changes

backends/apple/coreml/recipes/coreml_recipe_provider.py Outdated Show resolved Hide resolved

abhinaykukkadapu force-pushed the coreml_backend_recipes branch from cec4576 to 1ecbd40 Compare August 6, 2025 23:26

abhinaykukkadapu force-pushed the coreml_backend_recipes branch from 1ecbd40 to 039aedd Compare August 7, 2025 00:37

abhinaykukkadapu force-pushed the coreml_backend_recipes branch from 039aedd to 742eda3 Compare August 7, 2025 00:46

abhinaykukkadapu force-pushed the coreml_backend_recipes branch from 742eda3 to 863bdaa Compare August 7, 2025 00:47

abhinaykukkadapu force-pushed the coreml_backend_recipes branch from 863bdaa to 8d00ffc Compare August 7, 2025 16:25

abhinaykukkadapu force-pushed the coreml_backend_recipes branch from 2dc56a5 to e64572a Compare August 7, 2025 19:27

metascroy approved these changes Aug 7, 2025

View reviewed changes

abhinaykukkadapu force-pushed the coreml_backend_recipes branch from e64572a to 44c4954 Compare August 8, 2025 16:30

abhinaykukkadapu force-pushed the coreml_backend_recipes branch from 44c4954 to 4c34f87 Compare August 8, 2025 16:50

abhinaykukkadapu merged commit c671b92 into pytorch:main Aug 8, 2025
103 of 109 checks passed

abhinaykukkadapu deleted the coreml_backend_recipes branch August 8, 2025 17:09

abhinaykukkadapu mentioned this pull request Aug 10, 2025

Add coreml quant recipes #13265

Merged

abhinaykukkadapu mentioned this pull request Aug 13, 2025

[executorch] Add coreml quant recipes #13387

Merged

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025

[Executorch][Recipes][Coreml] Add coreml backend recipes (pytorch#13121)

c008551

[Executorch][Recipes][Coreml] Add coreml backend recipes #13121

[Executorch][Recipes][Coreml] Add coreml backend recipes #13121

Uh oh!

Conversation

abhinaykukkadapu commented Aug 5, 2025

Summary

Test plan

Uh oh!

pytorch-bot bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13121

⏳ No Failures, 78 Pending

Uh oh!

github-actions bot commented Aug 5, 2025

This PR needs a release notes: label

Uh oh!

Uh oh!

facebook-github-bot commented Aug 5, 2025

Uh oh!

facebook-github-bot commented Aug 5, 2025

Uh oh!

Uh oh!

metascroy Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metascroy Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

kimishpatel Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

metascroy Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

abhinaykukkadapu Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

metascroy Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

abhinaykukkadapu Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Aug 8, 2025

Uh oh!

facebook-github-bot commented Aug 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pytorch-bot bot commented Aug 5, 2025 •

edited

Loading

This PR needs a `release notes:` label