Fix XNNPACK build on Windows

.github/workflows/build-presets.yml

@@ -109,7 +109,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        preset: [pybind]
+        preset: [pybind, windows]
     with:
       job-name: build
       ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
@@ -119,14 +119,24 @@ jobs:
         set -eux
         conda init powershell
         powershell -Command "& {
-          \$ErrorActionPreference = 'Stop'
           Set-PSDebug -Trace 1
+          \$ErrorActionPreference = 'Stop'
+          \$PSNativeCommandUseErrorActionPreference = \$true
 
           conda create --yes --quiet -n et python=3.12
           conda activate et
 
           python install_requirements.py
           cmake --preset ${{ matrix.preset }}
+          if (\$LASTEXITCODE -ne 0) {
+            Write-Host "CMake configuration was unsuccessful. Exit code: \$LASTEXITCODE."
+            exit \$LASTEXITCODE
+          }
+
           \$numCores = [System.Environment]::GetEnvironmentVariable('NUMBER_OF_PROCESSORS') - 1
           cmake --build cmake-out -j \$numCores
+          if (\$LASTEXITCODE -ne 0) {
+            Write-Host "CMake build was unsuccessful. Exit code: \$LASTEXITCODE."
+            exit \$LASTEXITCODE
+          }
         }"

CMakePresets.json

@@ -150,6 +150,21 @@
             ]
         }
     },
+    {
+      "name": "windows",
+      "displayName": "Build ExecuTorch for Windows",
+      "inherits": ["common"],
+      "cacheVariables": {
+        "CMAKE_SYSTEM_NAME": "Windows",
+        "EXECUTORCH_BUILD_PRESET_FILE": "${sourceDir}/tools/cmake/preset/windows.cmake"
+      },
+      "toolset": "ClangCL",
+      "condition": {
+        "lhs": "${hostSystemName}",
+        "type": "equals",
+        "rhs": "Windows"
+      }
+    },
     {
         "name": "zephyr",
         "displayName": "Build ExecuTorch for Zephyr RTOS",

backends/xnnpack/CMakeLists.txt

@@ -59,7 +59,7 @@ foreach(fbs_file ${_xnnpack_schema__srcs})
   )
 endforeach()
 
-if(WIN32 AND NOT CMAKE_CROSSCOMPILING)
+if(${CMAKE_HOST_SYSTEM_NAME} STREQUAL "Windows")
   set(MV_COMMAND
       powershell -Command
       "Move-Item -Path ${_xnnpack_flatbuffer__outputs} -Destination ${_xnnpack_schema__outputs}"

devtools/bundled_program/CMakeLists.txt

@@ -20,7 +20,7 @@ foreach(schema_file ${_schema_files})
   )
 endforeach()
 
-file(MAKE_DIRECTORY ${DEVTOOLS_INCLUDE_DIR}/executorch/devtools/bundled_program)
+file(MAKE_DIRECTORY ${DEVTOOLS_INCLUDE_DIR_NO_BUILD_INTERFACE}/executorch/devtools/bundled_program)
 add_custom_command(
   OUTPUT ${_schema_outputs}
   COMMAND

tools/cmake/preset/windows.cmake

@@ -0,0 +1,27 @@
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+# All rights reserved.
+#
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+
+# keep sorted
+set_overridable_option(EXECUTORCH_BUILD_EXTENSION_DATA_LOADER ON)
+set_overridable_option(EXECUTORCH_BUILD_EXTENSION_EVALUE_UTIL ON)
+set_overridable_option(EXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR ON)
+set_overridable_option(EXECUTORCH_BUILD_EXTENSION_MODULE ON)
+set_overridable_option(EXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL ON)
+set_overridable_option(EXECUTORCH_BUILD_EXTENSION_TENSOR ON)
+set_overridable_option(EXECUTORCH_BUILD_XNNPACK ON)
+
+# These XNNPACK options don't currently build on Windows.
+set_overridable_option(XNNPACK_ENABLE_AVX256SKX OFF)
+set_overridable_option(XNNPACK_ENABLE_AVX256VNNI OFF)
+set_overridable_option(XNNPACK_ENABLE_AVX256VNNIGFNI OFF)
+set_overridable_option(XNNPACK_ENABLE_AVX512BF16 OFF)
+
+# Below options are not yet buildable on Windows, but should be.
+set(EXECUTORCH_BUILD_PORTABLE_OPS OFF CACHE BOOL "")
+#set_overridable_option(EXECUTORCH_BUILD_EXECUTOR_RUNNER ON)
+#set_overridable_option(EXECUTORCH_BUILD_KERNELS_OPTIMIZED ON)
+#set_overridable_option(EXECUTORCH_BUILD_KERNELS_QUANTIZED ON)