Skip to content

Fix XNNPACK build on Windows #13259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Fix build on Windows, re-enable Windows build CI job
merged 43 commits into from
Aug 26, 2025
Merged

Fix XNNPACK build on Windows #13259

merged 43 commits into from
Aug 26, 2025

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 9, 2025 •
edited
Loading

Fix a few build-blocking issues on Windows. Enable XNNPACK on the Windows preset. This also gives CI coverage.

I've disabled 4 microkernel families that don't build currently. These likely need to be gated or fixed upstream, but I'm disabling them locally for now to unblock usage. They are relatively niche and should have little to no perf impact on the average user.

GregoryComer and others added 11 commits August 8, 2025 14:44
@GregoryComer
Update
94c4f20 
[ghstack-poisoned]
@GregoryComer
Update
352c059 
[ghstack-poisoned]
@GregoryComer
Update
d8f8b12 
[ghstack-poisoned]
@GregoryComer
Update
8e8b78c 
[ghstack-poisoned]
@GregoryComer
Update
9cfd2b6 
[ghstack-poisoned]
@GregoryComer
Update
5b1330b 
[ghstack-poisoned]
@GregoryComer
Update
378fcdd 
[ghstack-poisoned]
@GregoryComer
Update
db12da0 
[ghstack-poisoned]
@GregoryComer
Update
4ee5cd0 
[ghstack-poisoned]
@GregoryComer
Update
b79f2e1 
[ghstack-poisoned]
@GregoryComer
Update
0abe592 
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Aug 9, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13259

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 44 Pending

As of commit 4dd225a with merge base 484ed13 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Aug 9, 2025
@GregoryComer
Fix XNNPACK build on Windows
bd7669b 
ghstack-source-id: cf9cd1c
ghstack-comment-id: 3172080268
Pull-Request: #13259
@GregoryComer GregoryComer mentioned this pull request Aug 9, 2025
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2025
This was referenced Aug 9, 2025
Merged
Merged
Merged
@GregoryComer GregoryComer marked this pull request as ready for review August 9, 2025 21:12
@GregoryComer GregoryComer mentioned this pull request Aug 9, 2025
Merged
GregoryComer and others added 7 commits August 9, 2025 20:12
@GregoryComer
Update
52b9ff1 
[ghstack-poisoned]
@GregoryComer
Update
c045a60 
[ghstack-poisoned]
@GregoryComer
Update
783cb51 
[ghstack-poisoned]
@GregoryComer
Update
0dc6f36 
[ghstack-poisoned]
@GregoryComer
Update
5fa2464 
[ghstack-poisoned]
@GregoryComer
Update
597dddd 
[ghstack-poisoned]
@GregoryComer
Update
7b45dac 
[ghstack-poisoned]
@GregoryComer
Update
1d7b71d 
[ghstack-poisoned]
@GregoryComer
Update
cd7fd0e 
[ghstack-poisoned]
@GregoryComer
Update
e346888 
[ghstack-poisoned]
@GregoryComer
Update
28605ca 
[ghstack-poisoned]
This was referenced Aug 20, 2025
Merged
Closed
@GregoryComer
Update
1423edb 
[ghstack-poisoned]
@GregoryComer
Update
ce55ae8 
[ghstack-poisoned]
@GregoryComer
Update
57d2e24 
[ghstack-poisoned]
@GregoryComer
Update
4404db8 
[ghstack-poisoned]
@GregoryComer
Update
e0a7a1d 
[ghstack-poisoned]
@GregoryComer
Update
faf1700 
[ghstack-poisoned]
@GregoryComer
Update
593055e 
[ghstack-poisoned]
@GregoryComer
Update
54b32b4 
[ghstack-poisoned]
Base automatically changed from gh/GregoryComer/115/head to main August 25, 2025 22:53
@GregoryComer
Update
efd02e4 
[ghstack-poisoned]
@GregoryComer GregoryComer mentioned this pull request Aug 25, 2025
Merged
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@GregoryComer
Update
4dd225a 
[ghstack-poisoned]
@GregoryComer GregoryComer mentioned this pull request Aug 25, 2025
Draft
@GregoryComer GregoryComer changed the base branch from main to gh/GregoryComer/141/head August 25, 2025 23:59
@GregoryComer
Update
a8edd06 
[ghstack-poisoned]
@GregoryComer GregoryComer merged commit 472df91 into gh/GregoryComer/141/head Aug 26, 2025
@GregoryComer GregoryComer deleted the gh/GregoryComer/117/head branch August 26, 2025 00:12
@GregoryComer
Copy link
Member Author

I'm not sure, why ghstack merged this when re-ordering PRs. I'll re-open as a new PR.

@GregoryComer GregoryComer mentioned this pull request Aug 26, 2025
Merged
GregoryComer added a commit that referenced this pull request Aug 27, 2025
@GregoryComer
Fix remaining build issues on Windows, re-enable Windows pybind prese…
4c4cbdf 
…t build CI job (#13702)

**Note: This is a cherry-pick of
#13564 and
#13259. I inadvertently broke
the ghstack when attempting to re-order the stack, leading to the old PR
being merged by ghstack into the ghstack-created branch (not main).**

Add mman_windows.cpp to the CMake sources. Fix a few build-blocking
issues with XNNPACK on Windows. Enable XNNPACK on the Windows preset.
This also gives CI coverage.

I've disabled 4 microkernel families that don't build currently. These
likely need to be gated or fixed upstream, but I'm disabling them
locally for now to unblock usage. They are relatively niche and should
have little to no perf impact on the average user.

With this change, the pybind preset works and we can re-enable it in CI.
@GregoryComer GregoryComer mentioned this pull request Aug 28, 2025
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jathu jathu jathu left review comments

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GregoryComer @jathu