Skip to content

Fix portable library build on Windows #13260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: gh/GregoryComer/117/head
Choose a base branch
from

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 9, 2025

Enable build of the portable operator library (and executor_runner, now that we have portable) on the Windows preset. There are a couple of patterns that weren't building on Windows. Both std::nan and std::signbit complain about ambiguous overload resolution when given an integer argument.

To solve the std::isnan issue, I introduced isnan_override in math_util.h, following the naming pattern from max_override / min_override / etc. in the same file. It adds a specialized branch for integers to avoid calling std::isnan. For std::signbit, I just locally specialized.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13260

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 6e6ab75 with merge base 4ce7078 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Aug 9, 2025
ghstack-source-id: e7bf6ba
ghstack-comment-id: 3172145648
Pull-Request: #13260
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2025
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 9, 2025
ghstack-source-id: 8bebedc
ghstack-comment-id: 3172145648
Pull-Request: #13260
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 9, 2025
ghstack-source-id: 10bf3ad
ghstack-comment-id: 3172145648
Pull-Request: #13260
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 10, 2025
ghstack-source-id: 9d42116
ghstack-comment-id: 3172145648
Pull-Request: #13260
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 10, 2025
ghstack-source-id: 05a414a
ghstack-comment-id: 3172145648
Pull-Request: #13260
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 10, 2025
ghstack-source-id: ced680d
ghstack-comment-id: 3172145648
Pull-Request: #13260
@GregoryComer GregoryComer marked this pull request as ready for review August 10, 2025 02:11
@GregoryComer
Copy link
Member Author

@manuelcandales Any thoughts or preference on the approach used here?

[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 10, 2025
ghstack-source-id: f13950b
ghstack-comment-id: 3172145648
Pull-Request: #13260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant