-
Couldn't load subscription status.
- Fork 700
Fix devtools CMake build failure on Windows #13251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13251
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Cancelled JobAs of commit faf1700 with merge base ffb47e3 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Note that the pybind preset failure is expected in the PR. It is resolved further up, as I incrementally fix issues. The other CI failures are pre-existing. |
|
@swolchok Can you sanity check this change? From looking at related code and your recent changes, I believe this is correct, but wanted to double check with you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand exactly why this is needed (what's the failure?) but it seems fine to me -- BUILD_INTERFACE prevents things from showing up post-installation and that doesn't seem to be relevant here.
Update the devtools bundled program build to work on Windows by using the non build interface string to create the directory. I'm not entirely sure why this was working on Mac/Linux, but looking at the other devtools cases where a directory was created at configuration time(?), it was using the non build interface path variable (DEVTOOLS_INCLUDE_DIR_NO_BUILD_INTERFACE), so this would appear to be the correct behavior. Note that the Windows pybind job is still failing on this PR, but is failing later. Without this change, the CMake configuration step fails. Now, it fails in the actual build - one step closer.
Update the devtools bundled program build to work on Windows by using the non build interface string to create the directory. I'm not entirely sure why this was working on Mac/Linux, but looking at the other devtools cases where a directory was created at configuration time(?), it was using the non build interface path variable (DEVTOOLS_INCLUDE_DIR_NO_BUILD_INTERFACE), so this would appear to be the correct behavior.
Note that the Windows pybind job is still failing on this PR, but is failing later. Without this change, the CMake configuration step fails. Now, it fails in the actual build - one step closer.