Skip to content

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 9, 2025

Update the devtools bundled program build to work on Windows by using the non build interface string to create the directory. I'm not entirely sure why this was working on Mac/Linux, but looking at the other devtools cases where a directory was created at configuration time(?), it was using the non build interface path variable (DEVTOOLS_INCLUDE_DIR_NO_BUILD_INTERFACE), so this would appear to be the correct behavior.

Note that the Windows pybind job is still failing on this PR, but is failing later. Without this change, the CMake configuration step fails. Now, it fails in the actual build - one step closer.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13251

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job

As of commit faf1700 with merge base ffb47e3 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2025
GregoryComer added a commit that referenced this pull request Aug 9, 2025
ghstack-source-id: eec99da
ghstack-comment-id: 3169574985
Pull-Request: #13251
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Aug 9, 2025
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 9, 2025
ghstack-source-id: 13d4a8a
ghstack-comment-id: 3169574985
Pull-Request: #13251
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 9, 2025
ghstack-source-id: 25bd759
ghstack-comment-id: 3169574985
Pull-Request: #13251
@GregoryComer GregoryComer marked this pull request as ready for review August 9, 2025 23:35
@GregoryComer GregoryComer requested review from jathu and swolchok August 11, 2025 20:50
GregoryComer and others added 4 commits August 13, 2025 17:00
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

Note that the pybind preset failure is expected in the PR. It is resolved further up, as I incrementally fix issues. The other CI failures are pre-existing.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

@swolchok Can you sanity check this change? From looking at related code and your recent changes, I believe this is correct, but wanted to double check with you.

Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand exactly why this is needed (what's the failure?) but it seems fine to me -- BUILD_INTERFACE prevents things from showing up post-installation and that doesn't seem to be relevant here.

Base automatically changed from gh/GregoryComer/111/head to main August 25, 2025 22:52
@GregoryComer GregoryComer merged commit 6ee6d7a into main Aug 25, 2025
103 of 281 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/114/head branch August 25, 2025 22:53
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
Update the devtools bundled program build to work on Windows by using
the non build interface string to create the directory. I'm not entirely
sure why this was working on Mac/Linux, but looking at the other
devtools cases where a directory was created at configuration time(?),
it was using the non build interface path variable
(DEVTOOLS_INCLUDE_DIR_NO_BUILD_INTERFACE), so this would appear to be
the correct behavior.

Note that the Windows pybind job is still failing on this PR, but is
failing later. Without this change, the CMake configuration step fails.
Now, it fails in the actual build - one step closer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants