Skip to content

Fix devtools CMake build failure on Windows #13251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: gh/GregoryComer/111/head
Choose a base branch
from

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 9, 2025

Update the devtools bundled program build to work on Windows by using the non build interface string to create the directory. I'm not entirely sure why this was working on Mac/Linux, but looking at the other devtools cases where a directory was created at configuration time(?), it was using the non build interface path variable (DEVTOOLS_INCLUDE_DIR_NO_BUILD_INTERFACE), so this would appear to be the correct behavior.

Note that the Windows pybind job is still failing on this PR, but is failing later. Without this change, the CMake configuration step fails. Now, it fails in the actual build - one step closer.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13251

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 4ee5cd0 with merge base 4ce7078 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2025
GregoryComer added a commit that referenced this pull request Aug 9, 2025
ghstack-source-id: eec99da
ghstack-comment-id: 3169574985
Pull-Request: #13251
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Aug 9, 2025
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 9, 2025
ghstack-source-id: 13d4a8a
ghstack-comment-id: 3169574985
Pull-Request: #13251
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 9, 2025
ghstack-source-id: 25bd759
ghstack-comment-id: 3169574985
Pull-Request: #13251
@GregoryComer GregoryComer marked this pull request as ready for review August 9, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant