Skip to content

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 21, 2025

I'm temporarily disabling tokenizers on Windows, as it does not currently build. I'll address this as a follow-up. It may be as simple as building with Clang. Since it's built through install_requirements.py -> pip, I need to figure out how to pass the toolset variable into the inner CMake build. May by a simple change in the tokenizers repo setup.py.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13567

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 3 Unrelated Failures

As of commit 607abf9 with merge base 484ed13 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2025
GregoryComer added a commit that referenced this pull request Aug 21, 2025
ghstack-source-id: 188be5a
ghstack-comment-id: 3208710885
Pull-Request: #13567
@GregoryComer GregoryComer marked this pull request as draft August 21, 2025 02:07
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 21, 2025
ghstack-source-id: d1be99f
ghstack-comment-id: 3208710885
Pull-Request: #13567
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 21, 2025
ghstack-source-id: 4dcd923
ghstack-comment-id: 3208710885
Pull-Request: #13567
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 21, 2025
ghstack-source-id: e979789
ghstack-comment-id: 3208710885
Pull-Request: #13567
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 21, 2025
ghstack-source-id: 906d2f4
ghstack-comment-id: 3208710885
Pull-Request: #13567
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 21, 2025
ghstack-source-id: f0ad481
ghstack-comment-id: 3208710885
Pull-Request: #13567
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 21, 2025
ghstack-source-id: 5943d5e
ghstack-comment-id: 3208710885
Pull-Request: #13567
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 25, 2025
ghstack-source-id: 50a9d39
ghstack-comment-id: 3208710885
Pull-Request: #13567
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 25, 2025
ghstack-source-id: 02eab8c
ghstack-comment-id: 3208710885
Pull-Request: #13567
@GregoryComer GregoryComer changed the base branch from gh/GregoryComer/136/head to gh/GregoryComer/138/head August 25, 2025 23:17
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 25, 2025
ghstack-source-id: a1607e9
ghstack-comment-id: 3208710885
Pull-Request: #13567
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 26, 2025
ghstack-source-id: a1607e9
ghstack-comment-id: 3208710885
Pull-Request: #13567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant